Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896193 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #5 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Wesley - This is a snapshot and pre-release package, please follow the recommendations are explained on [1] and [2] Where Release Tag for Pre-Release Packages: 0.%{X}.%{alphatag} Where %{X} = is the release number increment and %{alphatag} = is the string that came from the version (20130121bzr731) - In this line: cp -r %{buildroot}%{_datadir}/icons/hicolor/ %{buildroot}%{_datadir}/icons/gnome Actually the icons are not broken, simply use proper scriptlets [2] - the url should be [4] not http://wiki.go-docky.com/index.php - This package builds in gtk2 and gtk3 with their respectives dependencies, take a look in [5] - Please note that upstream accepts no Fedora related bugs [6] - Please take a look at your rpmlint output rpmlint -vi plank-0.2.0.731-1.20130121.fc17.x86_64.rpm plank.x86_64: W: shared-lib-calls-exit /usr/lib64/libplank.so.0.0.0 exit@GLIBC_2.2.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. - checking for DBUSMENU... no As an aside, one of the unfulfilled dependencies of this package is libdebusmenu, although I do not understand why it was not included in Fedora, being a approved package , I recommend that you take a look at this link [7] [1] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages [2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages [3] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache [4] https://launchpad.net/plank [5] http://wiki.go-docky.com/index.php?title=Plank:Installing [6] http://wiki.go-docky.com/index.php?title=Plank:Introduction#Reporting_Bugs [7] bug 842509 Btw, is available rev 734 Regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GRNoiZwV5M&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review