Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895667 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to comment #3) > $ polymake-config --ldflags > -L/usr/lib64 -Wl,-z,relro -Wl,--as-needed -Wl,-rpath,/usr/lib64 > should not add rpath. Fixed. > I believe should use some __provides_exclude_from pattern to > not "rpm --provides" most/all perl(.*) because they are not > installed in a perl standard search directory. Good point. Fixed. > After check licensecheck output, I notice there are several > BSD 2/3 clause licensed files, but those are the jreality > java sources, so, unless building the java interface, should > keep the GPLv2+ license tag, but I suggest at least some > basic tests in building jreality from sources. I have had some experimental jReality/jTEM packages available on my web page for quite some time: http://jjames.fedorapeople.org/. However, (a) they still need some work, and (b) jReality uses a version of itext that has an unacceptable license. I need to see if it can be backported to the version of itext that is currently in Fedora. > Some experiment should be done with: > ---%<--- > ifdef .svn > > ### unit tests > > test : compile > ${CallPolymake} --script run_testcases $(if $(filter > k,$(MAKEFLAGS)),--keep-going,--coverage) --applications ${Apps} > > ### maintenance > > tagsFLAGS = -R -e -f $@ --exclude=.svn --exclude='.\#*' --exclude='\#*' > --exclude='*~' > > TAGS: > ctags ${tagsFLAGS} --language-force=c++ lib apps/*/{src,include} > RTAGS: > ctags ${tagsFLAGS} --language-force=perl --exclude=testsuite \ > perl perllib apps/*/{perllib,rules,scripts} > scripts support/*.pl apps/*/testsuite/*/test*.pl > > include support/export.make > > endif # .svn > ---%<--- > at least to move the "test" target out of the .svn conditional. Doesn't work: /usr/bin/perl perl/polymake --script run_testcases --coverage --applications common polytope group graph matroid fan tropical topaz polymake: WARNING: created private directory /builddir/.polymake script file 'run_testcases' not found Apparently the test drivers are only available in subversion, which explains the .svn conditional. I don't see what I can do here, so I have removed the %check script and added an explanatory note to the spec file. > Issues: > ======= > [!]: Large documentation must go in a -doc subpackage. > Note: Documentation size is 2959360 bytes in 32 files. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Done. Actually, it was done before, but I gave you the wrong SRPM.... > Need to confirm documentation is not required by runtime, but I > think it is, and in that case not much of a point in creating > a -doc subpackage. It doesn't seem to be required by runtime. The documentation *sources* are, which is why they are in %{_datadir}/polymake/xml in the main package. > Again :-), srpm spec and spec do not match. This time it appears the > spec not in the srpm should be used, based on the diff... Argh, how do I keep doing that? There's clearly something wrong with my workflow.... New URLs: Spec URL: http://jjames.fedorapeople.org/polymake/polymake.spec SRPM URL: http://jjames.fedorapeople.org/polymake/polymake-2.12-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MEeph2vkO2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review