[Bug 901496] Review Request: perl-Email-Received - Parse an email Received: header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=901496

--- Comment #4 from Petr Šabata <psabata@xxxxxxxxxx> ---
Ok, using
http://bochecha.fedorapeople.org/packages/perl-Email-Received-1.00-1.fc18.src.rpm
:)

As usually, missing BRs :)
perl(base)
perl(constant)
perl(Exporter)
perl(Test)
perl(Test::More)

You can substitute the %{__perl} macro with simple 'perl'. (lines 17 and 31;
optional)

Also, Fedora Guidelines recommend using US English in Summary and Description. 
Consider replacing 'analysing' with 'analyzing'.

Switch from PERL_INSTALL_ROOT to DESTDIR unless you have your reasons not to.

The rest is okay.  No other issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BuGf8UCn2m&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]