Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847160 --- Comment #20 from Gerard Ryan <gerard@xxxxxxx> --- (In reply to comment #17) > === Issues === > 1. Apparently the URL of the source has changed, please review and fix it if > needed. > 2. Don't include the javadoc.sh script in the package. > 3. Add the jpackage-utils requirement to the javadoc package. 1,2,3 are done, I'll post new spec/srpm when the other issues are clarified. > 4. Remove the .jar files included in the tarball before building. The jar files are being removed before building, see line 194: find -name '*.jar' -delete Will that suffice? > 5. Install the POM files (I am not sure this is mandatory for Eclipse related > packages). Hmm, I'm not sure about this one either. I'll enquire of the Eclipse guys tomorrow. I don't know if they would be used in any case. I've used this package as a dependency in a local maven/tycho build for eclipse-jbosstools-openshift, and it didn't complain about not finding it. I'm guessing tycho uses information from OSGi manifests to resolve dependencies. I'll get clarification before going any further. (In reply to comment #18) > In Fedora Rawhide all javadoc packages have auto-generated "Require: > jpackage-utils", there is no need to explicitly specify it in the spec file. Is it still necessary for F18? If so, I'll add it back in. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fbPxcHTbum&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review