Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lshw - Hardware Lister (lshw) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229591 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: lshw - |Review Request: lshw - |Hardware Lister (lshw) |Hardware Lister (lshw) Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-22 14:21 EST ------- For a start: - It would have made life easier for reviewers if you had provided links to the spec and src.rpm, not to a tar - Vendor should not be used, it will set by the build system - Source should be a full URL to the downloadable file - BuildRoot does not respect the current mandatory value (you can leave it alone for now, the value is still under discussion) as specified by wiki/PackagingGuidelines - There is no Changelog entry More comments later -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review