Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889546 --- Comment #4 from Vinzenz Feenstra <vfeenstr@xxxxxxxxxx> --- (In reply to comment #3) > Issues: > ======= > - gtk-update-icon-cache is invoked when required > Note: icons in ovirt-guest-agent-gdm-plugin > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache OK Will be done > - post/postun scriptlets of kdm-plugin See below > - noreplace on some things, just because user *can* break stuff by > configuring something doesn't mean it should be forbidden. Especially the > pam configuration. Most likely also /etc/security/ and dbus files. There are > no simple reasons for admins to touch them, but if they do-> they obviously > had their reasons. See below > [!]: %config files are marked noreplace or the reason is justified. > Note: No (noreplace) in %config /etc/pam.d/ovirt-locksession %config > /etc/pam.d/ovirt-shutdown %config /etc/pam.d/ovirt-hibernate %config > %attr (644,root,root) /etc/udev/rules.d/55-ovirt-guest-agent.rules > %config /etc/dbus-1/system.d/org.ovirt.vdsm.Credentials.conf %config > /etc/security/console.apps/ovirt-locksession %config > /etc/security/console.apps/ovirt-shutdown %config > /etc/security/console.apps/ovirt-hibernate %config /etc/pam.d/gdm- > ovirtcred %config /etc/pam.d/kdm-ovirtcred > > I'd prefer if this was discussed on packaging mailing list. From my POV, I'd > say > it should be possible that local administrator will want to modify security > policies or pam settings and you should not overwrite his changes blindly on > updates. Well I actually thought so myself, however I was asked to put it like this. But I'd rather obey fedora rules. If someone messes with this files and doesn't know what they are doing they have to fix it by themselves. -> Will be changed > [!]: Scriptlets must be sane, if used. > > I *really* don't like post/postun of kdm-plugin subpackage. You are modifying > configuration of another package. IMO that's road to hell. > OK I'll remove it. This has to be solved then differently. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uJoSxg9qQw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review