Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901387 --- Comment #4 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > TODO: Replace PERL_INSTALL_ROOT variable with DESTDIR in %install section. > > > Current ExtUtils::MakeMaker understands DESTDIR. > > > > Out of curiosity, do you know what is the minimal version of > > ExtUtils::MakeMaker which started understanding DESTDIR? (to avoid closing > > the door to EPEL builds, in this package or in my future submissions) > > > According to ExtUtils::MakeMaker changelog > <http://cpansearch.perl.org/src/MSCHWERN/ExtUtils-MakeMaker-6.64/Changes>, > the support was added in version 6.06_01. But then there were various bugs > discovered. I don't know since when exactly it's reliable. Ok, so I'd rather keep PERL_INSTALL_ROOT for some time then. > > > TODO: Specify version constrain `>= 1.14' at perl(Test::Pod) (t/pod.t:4). > > > TODO: Specify version constrain `>= 1.04' at perl(Test::Pod::Coverage) > > > (t/pod-coverage.t:4). > > > > Is that really necessary? > > > > I mean, even EPEL 4 has recent enough versions... > > In general, I'm not friend of implicit dependencies. Specifying exact > dependencies makes the package safer and more portable. (Imagine someone > could try the package on older or completely different distribution.) Point taken. Fixed. (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > TODO: You can replace %{__perl} macro with plain perl command. > > > > Fixed. > > > Updated spec file is on the same address? I hadn't pushed it, because you had approved the package and asked to fix before building for Fedora. But since I commented here, I should have anyway. Here it is: Spec URL: http://bochecha.fedorapeople.org/packages/perl-Text-Affixes-0.07-2.fc18.src.rpm SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Text-Affixes.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X7GJhR8Mww&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review