Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895480 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-ClamAV-Client.spec.old 2013-01-15 11:06:19.000000000 +0100 +++ perl-ClamAV-Client.spec 2013-01-22 04:40:16.000000000 +0100 @@ -1,7 +1,7 @@ Name: perl-ClamAV-Client Summary: Client class for the ClamAV clamd virus scanner daemon Version: 0.11 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL+ or Artistic URL: http://search.cpan.org/dist/ClamAV-Client/ Source0: http://www.cpan.org/authors/id/J/JM/JMEHNLE/clamav-client/ClamAV-Client-%{version}.tar.gz @@ -10,7 +10,11 @@ BuildRequires: perl(Module::Build) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) + +# These are not found by rpmbuild +Requires: perl(IO::Socket::INET) +Requires: perl(IO::Socket::UNIX) %{?perl_default_filter} @@ -26,7 +30,7 @@ %build -%{__perl} Build.PL installdirs=vendor +perl Build.PL installdirs=vendor ./Build @@ -47,5 +51,9 @@ %changelog +* Tue Jan 22 2013 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> - 0.11-2 +- Replace usage of the %%{__perl} macro by the plain perl command. +- Add two run-time requirements missed by rpmbuild. + * Tue Jan 15 2013 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> - 0.11-1 - Initial package for Fedora, with help from cpanspec. > TODO: You can replace %{__perl} macros with plain perl command. -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) -%{__perl} Build.PL installdirs=vendor +perl Build.PL installdirs=vendor Ok. > FIX: Run-require `perl(IO::Socket::INET)' (lib/ClamAV/Client.pm:387). +Requires: perl(IO::Socket::INET) Ok. > FIX: Run-require `perl(IO::Socket::UNIX)' (lib/ClamAV/Client.pm:448). +Requires: perl(IO::Socket::UNIX) Ok. $ rpmlint perl-ClamAV-Client.spec ../SRPMS/perl-ClamAV-Client-0.11-2.fc19.src.rpm ../RPMS/noarch/perl-ClamAV-Client-0.11-2.fc19.noarch.rpm perl-ClamAV-Client.src: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.src: W: spelling-error %description -l en_US clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error %description -l en_US clamd -> clams, clam, clad 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-ClamAV-Client-0.11-2.fc19.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(Carp) 1 perl(ClamAV::Config) 1 perl(constant) 1 perl(Error) 1 perl(Error::Simple) 1 perl(IO::File) 1 perl(IO::Socket) 1 perl(IO::Socket::INET) 1 perl(IO::Socket::UNIX) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-ClamAV-Client-0.11-2.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4892697). Ok. Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mUPyk8ajJi&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review