Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902582 Ian Weller <ian@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+ --- Comment #3 from Ian Weller <ian@xxxxxxxxxxxxx> --- ________________________________________________________________ / In the future you should always bump the release number in the \ | specfile even if posting a new URL ruins a joke. | | | | Using the checklist available at: | | http://fedoraproject.org/wiki/Packaging:ReviewGuidelines | | | | [OK] rpmlint must be run: cowsay-beefymiracle.noarch: W: | | no-documentation | | | | [OK] follow Package Naming Guidelines | | | | [OK] spec filename matches %{name} | | | | [OK] meets Packaging Guidelines | | | | [OK] license is Fedora-approved | | | | [OK] license matches actual license | | | | [NA] license file included in %doc | | | | [OK] spec written in en_US | | | | [OK] spec legible unlike this review | | | | [OK] source sha256sums match (see below His Beefiness) | | | | [OK] package compiles on at least one arch | | | | [NA] ExcludeArches filed in BZ | | | | [OK] BuildRequires are good | | | | [NA] locales are not horrible | | | | [NA] ldconfig in %post and %postun | | | | [OK] no bundling | | | | [NA] something about relocatability | | | | [NA] owns directories it creates | | | | [OK] no %files duplicates | | | | [OK] permissions are a'ight | | | | [NA] macros are consistent | | | | [OK] contains code or permissable content | | | | [NA] large docs go in -doc | | | | [NA] %doc doesn't affect runtime | | | | [NA] static in -static | | | | [NA] devel in -devel | | | | [NA] -devel has fully-versioned dependency | | | | [OK] no libtool crap | | | | [NA] GUI has .desktop files | | | | [OK] doesn't own files from other packages | | | | [OK] filenames are UTF-8 | | | \ This package is APPROVED / ---------------------------------------------------------------- \ .---. __ , / \ \ |||| \\\\ |O___O | | \\|||| \ // | \_/ | | \ / '--/----/| / | |-' // // / -----' // \\ / / // // / / // \\ / / // // / / /| ' / / //\___/ / // ||\ / \\_ || '---' /' / \\_.- / / --| | '-' | | '-' 211dd37622d1629c6c6b82522bdc20c22f62a179888d72353c4e0fe193c4a454 beefymiracle.cow 211dd37622d1629c6c6b82522bdc20c22f62a179888d72353c4e0fe193c4a454 cowsay-beefymiracle-1.0-1.fc18.src/beefymiracle.cow Remember that the SCM admin request cannot be in cowsay because scripts -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NvuqE9Q4F5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review