Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895480 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source file is original (SHA-256: 2cf05681145d745269d6712c5ad424a10f381494123f568884d958d257e75246). Ok. Summary verified from README. Ok. Description verified from README. Ok. License verified from lib/ClamAV/Client.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: You can replace %{__perl} macros with plain perl command. No tests, not run-time dependencies are needed at build-time. Ok. `TODO' file does not contain any useful data. Not packaging it is Ok. $ rpmlint perl-ClamAV-Client.spec ../SRPMS/perl-ClamAV-Client-0.11-1.fc19.src.rpm ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm perl-ClamAV-Client.src: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.src: W: spelling-error %description -l en_US clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error Summary(en_US) clamd -> clams, clam, clad perl-ClamAV-Client.noarch: W: spelling-error %description -l en_US clamd -> clams, clam, clad 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Jan 21 17:15 /usr/share/doc/perl-ClamAV-Client-0.11 -rw-r--r-- 1 root root 346 Jan 21 2005 /usr/share/doc/perl-ClamAV-Client-0.11/CHANGES -rw-r--r-- 1 root root 606 Jan 21 2005 /usr/share/doc/perl-ClamAV-Client-0.11/README -rw-r--r-- 1 root root 4138 Jan 21 17:15 /usr/share/man/man3/ClamAV::Client.3pm.gz -rw-r--r-- 1 root root 2319 Jan 21 17:15 /usr/share/man/man3/ClamAV::Config.3pm.gz drwxr-xr-x 2 root root 0 Jan 21 17:15 /usr/share/perl5/vendor_perl/ClamAV -rw-r--r-- 1 root root 14715 Jan 21 17:15 /usr/share/perl5/vendor_perl/ClamAV/Client.pm -rw-r--r-- 1 root root 3223 Jan 21 17:15 /usr/share/perl5/vendor_perl/ClamAV/Config.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm | sort |uniq -c 1 perl(base) 1 perl(Carp) 1 perl(ClamAV::Config) 1 perl(constant) 1 perl(Error) 1 perl(Error::Simple) 1 perl(IO::File) 1 perl(IO::Socket) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(IO::Socket::INET)' (lib/ClamAV/Client.pm:387). FIX: Run-require `perl(IO::Socket::UNIX)' (lib/ClamAV/Client.pm:448). $ rpm -q --provides -p ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm | sort |uniq -c 1 perl(ClamAV::Client) = 0.11 1 perl-ClamAV-Client = 0.11-1.fc19 1 perl(ClamAV::Client::Error) 1 perl(ClamAV::Config) = 0.11 1 perl(ClamAV::Config::Error) Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-ClamAV-Client-0.11-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4889977). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4Rpq4KL62H&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review