Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868531 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source file is original (SHA-256: c336f5430b02714f70e374fb7dd45a44e13bd873f74761391b9ac7324a10814a). Ok. Summary verified from lib/ZMQ/LibZMQ3.pm. Ok. Description verified from lib/ZMQ/LibZMQ3.pm. Ok. License verified from lib/ZMQ/LibZMQ3.pm. Ok. This package contains XS code, architecture specific BuildArch is Ok. TODO: Build-require `perl(Devel::PPPort)' (inc/Module/Install/XSUtil.pm:135). TODO: Build-require `perl(XSLoader) >= 0.02' (lib/ZMQ/LibZMQ3.pm:5). TODO: Build-require `perl(base)' (lib/ZMQ/LibZMQ3.pm:4). TODO: Build-require `perl(Exporter)' (lib/ZMQ/LibZMQ3.pm:4). FIX: Build-require `perl(threads)' (t/101_threads.t:11). TODO: BUild-require `perl(Storable)' (t/100_basic.t:11). TODO: Build-require and package optional `perl(Proc::Guard)' (t/rt74653.t:3). All test pass. Ok. $ rpmlint perl-ZMQ-LibZMQ3.spec ../SRPMS/perl-ZMQ-LibZMQ3-1.08-1.fc19.src.rpm ../RPMS/x86_64/perl-ZMQ-LibZMQ3-* perl-ZMQ-LibZMQ3.src: W: spelling-error Summary(en_US) libzmq -> Librium perl-ZMQ-LibZMQ3.x86_64: W: spelling-error Summary(en_US) libzmq -> Librium 3 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-ZMQ-LibZMQ3-1.08-1.fc19.x86_64.rpm drwxr-xr-x 2 root root 0 Jan 21 15:17 /usr/lib64/perl5/vendor_perl/ZMQ -rw-r--r-- 1 root root 20812 Jan 19 07:18 /usr/lib64/perl5/vendor_perl/ZMQ/LibZMQ3.pm drwxr-xr-x 2 root root 0 Jan 21 15:17 /usr/lib64/perl5/vendor_perl/auto/ZMQ drwxr-xr-x 2 root root 0 Jan 21 15:17 /usr/lib64/perl5/vendor_perl/auto/ZMQ/LibZMQ3 -rwxr-xr-x 1 root root 82200 Jan 21 15:17 /usr/lib64/perl5/vendor_perl/auto/ZMQ/LibZMQ3/LibZMQ3.so drwxr-xr-x 2 root root 0 Jan 21 15:18 /usr/share/doc/perl-ZMQ-LibZMQ3-1.08 -rw-r--r-- 1 root root 4495 Jan 19 07:17 /usr/share/doc/perl-ZMQ-LibZMQ3-1.08/Changes -rw-r--r-- 1 root root 8411 Jan 21 15:17 /usr/share/man/man3/ZMQ::LibZMQ3.3pm.gz File permission and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-ZMQ-LibZMQ3-1.08-1.fc19.x86_64.rpm | sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libzmq.so.3()(64bit) 1 perl(base) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 perl(ZMQ::Constants) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-ZMQ-LibZMQ3-1.08-1.fc19.x86_64.rpm | sort |uniq -c 1 perl(ZMQ::LibZMQ3) = 1.08 1 perl-ZMQ-LibZMQ3 = 1.08-1.fc19 1 perl-ZMQ-LibZMQ3(x86-64) = 1.08-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-ZMQ-LibZMQ3-1.08-1.fc19.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4889342). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YNDPlEGZVW&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review