Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884706 --- Comment #2 from Jan Safranek <jsafrane@xxxxxxxxxx> --- Thanks for the review! (In reply to comment #1) > [!]: Package contains no bundled libraries. > >>>> The package contains classes from the package > >>>> org.stathissideris.ascii2image. This package seems to have been written by > >>>> Sathis Sideris for the ditaa project unrelated to this package, therefore > >>>> I conclude it's a bundled library, albeit it's provided by upstream. The > >>>> preferred course of action is to package ditaa first and require it in > >>>> this package. Fortunately, upstream provides plantuml-lgpl, which contains the sources without any bundled libraries. The resulting application then lacks some features (e.g. output in ditaa format), but I don't miss anything important. Therefore I updated the .spec file to use the -lgpl tarball, which results in lot of changes, e.g. ant is used instead of maven. > > [!]: Javadoc documentation files are generated and included in -javadoc > subpackage > >>>> Please, instead of installing the JAR file with javadoc, use files > >>>> contained in target/site/apidocs/* , like this (line 64): > >>>> cp -rp target/site/apidocs/* $RPM_BUILD_ROOT%{_javadocdir}/%{name} I hope I fixed it, ant did not generate any javadoc so I added javadoc call to the spec file. > [!]: Package consistently uses macro is (instead of hard-coded directory > names). > >>>> On line 61, you are mentioning the jar by explicit version number. That > >>>> is not good for updating, please use plantuml-%{version}-SNAPSHOT.jar . Nice catch, but obsolete with new -lgpl tarball > > Notes: > ====== > > [x]: %build honors applicable compiler flags or justifies otherwise. > >>>> Using the 'install' target is unnecessary. If you have integration tests, > >>>> use 'mvn-rpmbuild verify', and if not, use 'mvn-rpmbuild package' Maven is gone. > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > >>>> Please, query upstream to include the licence file. Done > [!]: Latest version is packaged. > >>>> With the frequency that the upstream releases a new version (< 1 week), > >>>> I am not going to block the review on this requirement. However, please > >>>> make sure that this package is updated as quickly as possible. Done > > [x]: Package uses upstream build method (ant/maven/etc.) > >>>> I was not able to determine which buildsystem the upstream uses. Since > >>>> there are JARs in the upsteram repository that contain only the ant > >>>> buildfile, I assume the upstream is inclined towards ant, but I have > >>>> nothing written in stone. Done Updated sources: http://people.redhat.com/jsafrane/review/plantuml2/plantuml.spec http://people.redhat.com/jsafrane/review/plantuml2/plantuml-7950-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L5G5FXs308&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review