Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901611 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!]: Requires correct, justified where necessary. Missing: php-xml Requires: /usr/bin/env instead of /usr/bin/php => fix the shebang in /usr/bin/atoum [!]: %check is present and all tests pass. %check cd tests/units echo "date.timezone=UTC" >php.ini export PHPRC=$(pwd)/php.ini php runner.php --directories . [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the Clean as other EL-5 stuff not present [!]: License field in the package spec file matches the actual license. COPYING file is BSD (3 clauses), not MIT => probably worth asking upstream to add a license "header" in all files [!]: Package complies to the Packaging Guidelines Non-PEAR PHP software which provides shared libraries should put its PHP source files for such shared libraries in a subfolder of /usr/share/php. => this is not a library, so should rather use /usr/share/foo (perhaps "classes" could go in /usr/share/php, which is in PHP include_path) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EjgbF2u2nw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review