Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901594 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!]: Run phpci static analyze on all php files. phpci reports REQUIRED PHP 5.5.0-dev (MIN) which is, of course a false positive. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the Could be droped as other EL-5 stuff not present [!]: Description "PHP password_* function for 5.3 and 5.4" probably "PHP" missing" [!]: Comment in %check (not version 1.4.4) OK (30 tests, 30 assertions) [!]: test in PHP include_path Please move to /usr/share/tests/%{name} NB: need to own /usr/share/tests or require php-pear Only the latest seems a blocker (for me, nothing in Guidelines about this) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AVRxFMEbNw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review