Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891171 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #11 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to comment #9) > Description and Summary OK. > > > %nodejs_fixdep lru-cache 2.2.x > > %nodejs_fixdep init-package-json 0.0.x > TODO: Have you contacted upstream about that? > > MUST: rpmlint must be run on the source rpm and all binary rpms the build > produces. > > $ rpmlint ../SRPMS/npm-1.2.1-1.fc18.src.rpm > ../RPMS/noarch/npm-1.2.1-1.fc18.noarch.rpm > npm.src: W: spelling-error Summary(en_US) js -> dis, ks, j > npm.src: W: spelling-error %description -l en_US js -> dis, ks, j > False. Node.js. > > npm.src: W: invalid-license MITNFA > False. Old rpmlint. > > npm.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j > npm.noarch: W: spelling-error %description -l en_US js -> dis, ks, j > False. Node.js. > > npm.noarch: W: invalid-license MITNFA > False. Old rpmlint. > > npm.noarch: W: only-non-binary-in-usr-lib > False. Node.js. > > npm.noarch: W: dangling-symlink > /usr/lib/node_modules/npm/node_modules/node-gyp > /usr/lib/node_modules/node-gyp > Symlink OK, package requires npm(node-gyp) > > npm.noarch: W: dangling-symlink /usr/lib/node_modules/npm/node_modules/archy > /usr/lib/node_modules/archy > Symlink OK, package requires npm(archy) > > npm.noarch: W: dangling-symlink /usr/lib/node_modules/npm/node_modules/glob > /usr/lib/node_modules/glob > Symlink OK, package requires npm(glob) > > npm.noarch: E: script-without-shebang > /usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp.cmd > Positive, FIX. This is a Windows batch file and should just be removed. Fixed. > npm.noarch: E: script-without-shebang > /usr/lib/node_modules/npm/bin/read-package-json.js > Positive, FIX. Fixed. > npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-global.1.gz 153: > warning: macro `Consider' not defined > Rubish, rpmlint should be happy to even have a mapage :) I'll get to this later. > FIX: There are scripts without shebangs (see rpmlint output) and they > probably need no execute permission. Other files OK. Actually %{nodejs_libdir}/%{npm_name}/bin serves as kind of a %{_libexecdir} for node modules, so I'd like to keep the exec bit in case someone counts on it. > FIX: Move reneaming the manpages to %prep Fixed. (In reply to comment #10) > > npm.noarch: W: manual-page-warning /usr/share/man/man1/npm-global.1.gz 153: warning: macro `Consider' not defined > > Rubish, rpmlint should be happy to even have a mapage :) > > There is actually an error in syntax: > > > .Consider > > Please FIX it, preferably in the upstream. This is an outdated copy of folders.1: https://github.com/isaacs/npm/issues/3078 Fixed by just symlinking globals.1 to folders.1 so they're always in sync. Spec: http://patches.fedorapeople.org/npm/npm.spec SRPM: http://patches.fedorapeople.org/npm/npm-1.2.1-2.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4883760 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SvkpXKFySp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review