[Bug 895541] Review Request: ptbl - Periodic Table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895541

--- Comment #25 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
Both downloads are accessible, but why do you refuse to fix the permissions of
the files inside the src.rpm? This time it's the spec file:

  $ rpmlint ptbl-1.0-8.fc18.src.rpm 
  ptbl.src: W: strange-permission ptbl.spec 0600L
  1 packages and 0 specfiles checked; 0 errors, 1 warnings.

That could be due to a systematic error at your side, such as a wrong umask
value.

[...]

> install -p -D -m 0644 %{SOURCE2} %{buildroot}%{_datadir}/applications/ptbl.desktop

Indeed, re-reading the Desktop Files guidelines is recommended:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

  $ cat ptbl.desktop 
  [Desktop Entry]
  Type=Application
  Exec=ptbl
  Name=ptbl
  Categories=Utility;GTK;
  Icon=ptbl.png
  X-Desktop-File-Install-Version=0.21

The icon is not found so far.
https://fedoraproject.org/wiki/Packaging:Guidelines#Icon_tag_in_Desktop_Files

Name=Periodic Table
would be much better.


> Summary:       Periodic_Table

A dubious '_' in there. ;-)


> Source0:        http://download-mirror.savannah.gnu.org/releases/%{name}/%{name}-%{version}.tar.gz

This doesn't pass the guidelines yet:

| MUST: The sources used to build the package must match
| the upstream source, as provided in the spec URL. [...]
|
| https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

$ md5sum ptbl-1.0.tar.gz 
cbf3cedbe8a5a7909e7e2b033add7031  ptbl-1.0.tar.gz
$ rm -f ptbl-1.0.tar.gz 
$ spectool -g ptbl.spec 
...
$ md5sum ptbl-1.0.tar.gz 
8fcddcbbdfc2e5e07d1cd454b86703f3  ptbl-1.0.tar.gz


>  %description
> -Periodic Table application 
> +Periodic Table application. Each element shows a list of \
> +physical/chemical properties, mainly focusing at the need \
> +of Condensed Matter Physicist and Material Scientist. 

Backslashes at the end are unusual in %description and are NOT necessary.
https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y7CmT7ng2F&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]