Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Democracy - A internet TV video player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229651 rdieter@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@xxxxxxxxxxxx ------- Additional Comments From rdieter@xxxxxxxxxxxx 2007-02-22 09:48 EST ------- Awesome! A couple quick comments: 1. No need to %ghost .pyo files anymore, as a matter of fact, it is discouraged: http://fedoraproject.org/wiki/Packaging/Python 2. Use %find_lang instead of manually including locale bits: %{_datadir}/locale/*/LC_MESSAGES/democracyplayer.mo 3. You include %post update-desktop-database %{_datadir}/applications but not for %postun ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review