Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896744 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #2 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Andrew, You have plans to EL5? if not - %clean is not needed - BuildRoot is not needed - cleaning of buildroot in %install is not needed - %defattr is not needed Some initial issues: - You may not use your personal space as url of Source0, instead can do a comment on how the tarball was generated, e.g. # Sources from foo # git clone git://foo.com/foo.git # cd foo .... - In [1] can be read: "If the snapshot package is considered a "pre-release package", you should follow the guidelines listed in Pre-Release Packages for snapshot packages, using the %{checkout}..." You can use: %global checkout 26d4e95git Name: iotwatcher Version: 0.0 Release: 1.%{checkout}%{?dist} Source0: iowatcher-%{version}.%{checkout}.tar.gz - use DESTDIR to install [2] e.g. make install DESTDIR=%{buildroot} PREFIX=%{_prefix} instead of make prefix=%{buildroot}/usr install - in this line, preserve the timestamps: use install -p -m 0644 -D iowatcher.1 %{buildroot}%{_mandir}/man1/iowatcher.1 instead of install -m 0644 -D iowatcher.1 %{buildroot}%{_mandir}/man1/iowatcher.1 - Please review ownership of files and directories.[3] %{_bindir}/* %{_mandir}/man1/* - should honor compiler flags - Use %{?_smp_mflags} macro for the make command [1] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages [2] http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section [3] https://fedoraproject.org/wiki/Packaging:UnownedDirectories Best Regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6Pt5GLBbyY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review