Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=869618 Thorsten Leemhuis <fedora@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Thorsten Leemhuis <fedora@xxxxxxxxxxxxx> --- Review for this package: > Spec URL: http://lisas.de/~adrian/rpm/crtools.spec > SRPM URL: http://lisas.de/~adrian/rpm/crtools-0.3-1.fc18.src.rpm Rpmlint is clean. Found one blocker: The package guidelines say there must me a bug mentioned in the spec file for every ExcludeArch used; that section has a lot of "MUST" and I'd say it can be expected to apply to ExclusiveArch, too. So I'd say: file one bug and mention it in the spec file, that should be sufficient. A few nit-picks: - I wonder if the summary would benefit from a "Tool for " - Explaining what CRIU actually means in the description would be wise, too - would be good if upstream would include a install section in the Makefile and could fix the stack-protector problem -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jq7nLdf5Ja&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review