Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895479 --- Comment #6 from Jakub Hrozek <jhrozek@xxxxxxxxxx> --- Sorry I still found one issue with the URL. 1) The URL points to 404 $ spectool -gf cmocka.spec Getting https://open.cryptomilk.org/attachments/download/7/cmocka-0.2.0.tar.gz/cmocka-0.2.0.tar.gz to ./cmocka-0.2.0.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found Another issue was actually found by the fedora-review tool: [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text But I think it's wrong, the upstream tarball includes COPYING, you include it with %doc and it's present in the RPMs, too (/usr/share/doc/libcmocka-0.2.0/COPYING). So please just fix the URL and I'll approve. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qALjKjFXr1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review