Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=833226 --- Comment #10 from Jos de Kloe <josdekloe@xxxxxxxxx> --- Hi Scott, thanks for the updated version. I looked again at the package and (since I'm still learning about the review process) found a few other issues. the package still builds fine with mock: mock -r fedora-rawhide-x86_64 --rebuild python-pycparser-2.08-1.fc17.src.rpm generates these rpms: python-pycparser-2.08-1.fc19.noarch.rpm python-pycparser-2.08-1.fc19.src.rpm However rpmlint has some new warnings now: $ rpmlint python-pycparser-2.08-1.fc19.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python-pycparser-2.08-1.fc19.src.rpm python-pycparser.src: W: strange-permission remove-relative-sys-path 0755L python-pycparser.src: W: invalid-url Source0: http://pycparser.googlecode.com/files/pycparser-2.08.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 2 warnings. This introduces a problem with this requirement from the review guidelines: MUST: The sources used to build the package must match the upstream source, this is a problem now since upstream moved to a different location. The new source URL of the project is: https://bitbucket.org/eliben/pycparser However, I don't see version 2.08 listed here anymore. Latest versions are 2.09 and 2.09.1, but the one before is 2.07 Could you please either update to the latest released version, or change the source url to point to the right mercurial revision that matches your v2.08? (if you choose this you probably should contact upstream to ask which version this was, since it is not noted in mercurial comments or tags) The other rpmlint warning refers to this requirement: MUST: Permissions on files must be set properly. rpmlint complains about the permissions for the remove-relative-sys-path script. There is no need to have a write permission for this script, but then it doesn't hurt either I think since the script is not installed, but only used during the build of the rpm. Then there are additional requirements from: https://fedoraproject.org/wiki/Packaging:Python To build a package containing python2 files, you need to have BuildRequires: python2-devel this is currently missing in your spec file. Best regards, Jos -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2AVCNw64Fm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review