Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894119 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Just a few notes from me (not that I am taking the review) * Descriptive summary - Could you please provide better summary? Framework for some dynamic language list is not too helpful to know what is the package/framework good for. * No inclusion of pre-built binaries or libraries - It seems that you are shipping pre-build .jars. According to this guideline, you have to remove the original .jars and rebuild them from sources. Please note that I am not Java packaging expert, so I'll cannot help you with this further. * Split package into subpackages - It seems that there are shipped bindings for various other languages. I would suggest to split these into language specific subpackages. User could later choose just the subpackage (s)he needs and save some space. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gzdvW9cQcp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review