Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891173 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- TODO: Consider adding something about node.js to the Summary and/or Description. As there is no nodejs- prefix in the name. About the name: As there are not yet any usable guidelines, I don't know where the application group starts. There were packages in this scope with executable (notably nodejs-which), but they used the nodejs prefix. I suppose the question is: Will anyone need to install this package not as a dependency, but as an app to use? If yes, I am OK with no prefix. If not, I suppose, there should be a prefix. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint ../SRPMS/opener-1.3.0-2.fc18.src.rpm ../RPMS/noarch/opener-1.3.0-2.fc18.noarch.rpm opener.src: W: spelling-error Summary(en_US) webpages -> web pages, web-pages, passages opener.src: W: spelling-error Summary(en_US) executables -> executable, executable s, executrices opener.src: W: spelling-error %description -l en_US webpages -> web pages, web-pages, passages opener.src: W: spelling-error %description -l en_US executables -> executable, executable s, executrices opener.noarch: W: spelling-error Summary(en_US) webpages -> web pages, web-pages, passages opener.noarch: W: spelling-error Summary(en_US) executables -> executable, executable s, executrices opener.noarch: W: spelling-error %description -l en_US webpages -> web pages, web-pages, passages opener.noarch: W: spelling-error %description -l en_US executables -> executable, executable s, executrices opener.noarch: W: only-non-binary-in-usr-lib opener.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/opener-1.3.0/LICENSE.txt opener.noarch: E: non-executable-script /usr/lib/node_modules/opener/opener.js 0644L /usr/bin/env opener.noarch: W: no-manual-page-for-binary opener 2 packages and 0 specfiles checked; 1 errors, 11 warnings. FIX: wrong-file-end-of-line-encoding FIX: non-executable-script TODO: no-manual-page-for-binary All false positives. MUST: The package must be named according to the Package Naming Guidelines. ???? MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. Checked in LICENSE.txt, WTFPL. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/opener-1.3.0.tgz 8ce1113b83487849625156d72483e4eef7b8eebf63a9e8d7732df15c240efa06 ../SOURCES/opener-1.3.0.tgz $ spectool -g opener.spec Getting http://registry.npmjs.org/opener/-/opener-1.3.0.tgz to ./opener-1.3.0.tgz $ sha256sum opener-1.3.0.tgz 8ce1113b83487849625156d72483e4eef7b8eebf63a9e8d7732df15c240efa06 opener-1.3.0.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/opener-1.3.0-2.fc18.noarch.rpm lrwxrwxrwx 1 root root 36 led 17 12:37 /usr/bin/opener -> ../lib/node_modules/opener/opener.js drwxr-xr-x 2 root root 0 led 17 12:37 /usr/lib/node_modules/opener -rw-r--r-- 1 root root 967 zář 13 16:15 /usr/lib/node_modules/opener/README.md -rw-r--r-- 1 root root 1907 zář 13 16:15 /usr/lib/node_modules/opener/opener.js -rw-r--r-- 1 root root 607 zář 13 16:15 /usr/lib/node_modules/opener/package.json drwxr-xr-x 2 root root 0 led 17 12:37 /usr/share/doc/opener-1.3.0 -rw-r--r-- 1 root root 515 zář 13 16:15 /usr/share/doc/opener-1.3.0/LICENSE.txt Permissions OK. FIX: Move README.md to the %doc, or tell me, if it is a run time dependency. MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Package NEEDSWORK. Please solve the FIXes, consider solving TODOs and let me know about the name. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WrsK3wcDTW&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review