Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891178 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Description and Summary OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. $ rpmlint ../SRPMS/nodejs-archy-0.0.2-4.fc18.src.rpm ../RPMS/noarch/nodejs-archy-0.0.2-4.fc18.noarch.rpm nodejs-archy.src: W: spelling-error Summary(en_US) unicode -> Unicode, uni code, uni-code nodejs-archy.src: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code nodejs-archy.src: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-archy.src: W: invalid-url URL: https://github.com/substack/archy HTTP Error 404: Not Found nodejs-archy.noarch: W: spelling-error Summary(en_US) unicode -> Unicode, uni code, uni-code nodejs-archy.noarch: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code nodejs-archy.noarch: W: spelling-error %description -l en_US npm -> pm, rpm, ppm nodejs-archy.noarch: W: invalid-url URL: https://github.com/substack/archy HTTP Error 404: Not Found nodejs-archy.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 9 warnings. Symlink OK, package requires npm(inherits) FIX: URL should be https://github.com/substack/node-archy All others false positives. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK In README.markdown: MIT/X11 On GitHub: MIT MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/archy-0.0.2.tgz 355bafab4acbb86e4e94c00c55900215abe41ae72ab454be889c766e5889a6e5 ../SOURCES/archy-0.0.2.tgz $ spectool -g nodejs-archy.spec Getting http://registry.npmjs.org/archy/-/archy-0.0.2.tgz to ./archy-0.0.2.tgz $ sha256sum archy-0.0.2.tgz 355bafab4acbb86e4e94c00c55900215abe41ae72ab454be889c766e5889a6e5 archy-0.0.2.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, build in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-archy-0.0.2-4.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 17 08:52 /usr/lib/node_modules/archy -rw-r--r-- 1 root root 1140 bře 9 2012 /usr/lib/node_modules/archy/index.js drwxr-xr-x 2 root root 0 led 17 08:52 /usr/lib/node_modules/archy/node_modules -rw-r--r-- 1 root root 804 bře 9 2012 /usr/lib/node_modules/archy/package.json drwxr-xr-x 2 root root 0 led 17 08:52 /usr/share/doc/nodejs-archy-0.0.2 -rw-r--r-- 1 root root 1707 bře 9 2012 /usr/share/doc/nodejs-archy-0.0.2/README.markdown drwxr-xr-x 2 root root 0 led 17 08:52 /usr/share/doc/nodejs-archy-0.0.2/examples -rw-r--r-- 1 root root 387 bře 9 2012 /usr/share/doc/nodejs-archy-0.0.2/examples/beep.js -rw-r--r-- 1 root root 414 bře 9 2012 /usr/share/doc/nodejs-archy-0.0.2/examples/multi_line.js OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK TODO: Enable test when possible. Package NEEDSWORK: Correct the URL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nVGrC67oR2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review