Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891192 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- TODO: Longer Description. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. $ rpmlint ../SRPMS/nodejs-fstream-npm-0.1.3-2.fc18.src.rpm ../RPMS/noarch/nodejs-fstream-npm-0.1.3-2.fc18.noarch.rpm nodejs-fstream-npm.noarch: W: only-non-binary-in-usr-lib nodejs-fstream-npm.noarch: W: dangling-symlink /usr/lib/node_modules/fstream-npm/node_modules/inherits /usr/lib/node_modules/inherits nodejs-fstream-npm.noarch: W: dangling-symlink /usr/lib/node_modules/fstream-npm/node_modules/fstream-ignore /usr/lib/node_modules/fstream-ignore 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Symlinks OK, package requires npm(inherits), npm(fstream-ignore) All false positives. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK Checked in LICENSE, BSD. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/fstream-npm-0.1.3.tgz 2dcfe8b89bdeeed0d012617b1eeb0cf411cd9b5e836a9aba8f25502cee5c7d8c ../SOURCES/fstream-npm-0.1.3.tgz $ spectool -g nodejs-fstream-npm.spec Getting http://registry.npmjs.org/fstream-npm/-/fstream-npm-0.1.3.tgz to ./fstream-npm-0.1.3.tgz $ sha256sum fstream-npm-0.1.3.tgz 2dcfe8b89bdeeed0d012617b1eeb0cf411cd9b5e836a9aba8f25502cee5c7d8c fstream-npm-0.1.3.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, build in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-fstream-npm-0.1.3-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 17 07:48 /usr/lib/node_modules/fstream-npm -rw-r--r-- 1 root root 9273 říj 22 17:44 /usr/lib/node_modules/fstream-npm/fstream-npm.js drwxr-xr-x 2 root root 0 led 17 07:48 /usr/lib/node_modules/fstream-npm/node_modules lrwxrwxrwx 1 root root 36 led 17 07:48 /usr/lib/node_modules/fstream-npm/node_modules/fstream-ignore -> /usr/lib/node_modules/fstream-ignore lrwxrwxrwx 1 root root 30 led 17 07:48 /usr/lib/node_modules/fstream-npm/node_modules/inherits -> /usr/lib/node_modules/inherits -rw-r--r-- 1 root root 398 říj 22 17:44 /usr/lib/node_modules/fstream-npm/package.json drwxr-xr-x 2 root root 0 led 17 07:48 /usr/share/doc/nodejs-fstream-npm-0.1.3 -rw-r--r-- 1 root root 1318 čen 4 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/LICENCE -rw-r--r-- 1 root root 448 bře 27 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/README.md drwxr-xr-x 2 root root 0 led 17 07:48 /usr/share/doc/nodejs-fstream-npm-0.1.3/example -rw-r--r-- 1 root root 345 bře 27 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/example/bundle.js -rw-r--r-- 1 root root 548 bře 27 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/example/dir-tar.js -rw-r--r-- 1 root root 657 bře 27 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/example/dir.js -rw-r--r-- 1 root root 358 bře 27 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/example/example.js -rw-r--r-- 1 root root 545 bře 27 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/example/ig-tar.js -rw-r--r-- 1 root root 605 bře 27 2012 /usr/share/doc/nodejs-fstream-npm-0.1.3/example/tar.js OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK Package APPROVED. Consider writing a longer Description. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4nMupt8KP3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review