Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891191 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- TODO: Longer Description. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. $ rpmlint ../SRPMS/nodejs-fstream-ignore-0.0.5-3.fc18.src.rpm ../RPMS/noarch/nodejs-fstream-ignore-0.0.5-3.fc18.noarch.rpm nodejs-fstream-ignore.noarch: W: only-non-binary-in-usr-lib nodejs-fstream-ignore.noarch: W: dangling-symlink /usr/lib/node_modules/fstream-ignore/node_modules/inherits /usr/lib/node_modules/inherits nodejs-fstream-ignore.noarch: W: dangling-symlink /usr/lib/node_modules/fstream-ignore/node_modules/minimatch /usr/lib/node_modules/minimatch nodejs-fstream-ignore.noarch: W: dangling-symlink /usr/lib/node_modules/fstream-ignore/node_modules/fstream /usr/lib/node_modules/fstream 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Symlinks OK, package requires npm(minimatch), npm(inherits), npm(fstream) All false positives. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. MUST: The License field in the package spec file must match the actual license. $ grep -r MIT . $ grep -r granted . FIX: Explain, where does the information come from. MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ sha256sum ../SOURCES/fstream-ignore-0.0.5.tgz 68e284b92d298e39d66085149645fef738b10af19bf96fe95ae74fea9a06c17a ../SOURCES/fstream-ignore-0.0.5.tgz $ spectool -g nodejs-fstream-ignore.spec Getting http://registry.npmjs.org/fstream-ignore/-/fstream-ignore-0.0.5.tgz to ./fstream-ignore-0.0.5.tgz $ sha256sum fstream-ignore-0.0.5.tgz 68e284b92d298e39d66085149645fef738b10af19bf96fe95ae74fea9a06c17a fstream-ignore-0.0.5.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, build in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-fstream-ignore-0.0.5-3.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 17 07:33 /usr/lib/node_modules/fstream-ignore -rw-r--r-- 1 root root 7471 bře 27 2012 /usr/lib/node_modules/fstream-ignore/ignore.js drwxr-xr-x 2 root root 0 led 17 07:33 /usr/lib/node_modules/fstream-ignore/node_modules lrwxrwxrwx 1 root root 29 led 17 07:33 /usr/lib/node_modules/fstream-ignore/node_modules/fstream -> /usr/lib/node_modules/fstream lrwxrwxrwx 1 root root 30 led 17 07:33 /usr/lib/node_modules/fstream-ignore/node_modules/inherits -> /usr/lib/node_modules/inherits lrwxrwxrwx 1 root root 31 led 17 07:33 /usr/lib/node_modules/fstream-ignore/node_modules/minimatch -> /usr/lib/node_modules/minimatch -rw-r--r-- 1 root root 532 bře 27 2012 /usr/lib/node_modules/fstream-ignore/package.json drwxr-xr-x 2 root root 0 led 17 07:33 /usr/share/doc/nodejs-fstream-ignore-0.0.5 -rw-r--r-- 1 root root 621 bře 22 2012 /usr/share/doc/nodejs-fstream-ignore-0.0.5/README.md drwxr-xr-x 2 root root 0 led 17 07:33 /usr/share/doc/nodejs-fstream-ignore-0.0.5/example -rw-r--r-- 1 root root 351 bře 23 2012 /usr/share/doc/nodejs-fstream-ignore-0.0.5/example/basic.js OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. TODO: Query upstream to include LICENSE. Don't forget to redownload the source, as Isaac seems to not worry about bumping the version number for that. SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK TODO: Testy test... don't want to repeat myself. Package NEEDSWORK: Correct the license thing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aoQotE6VuC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review