Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=825409 --- Comment #5 from Rich Mattes <richmattes@xxxxxxxxx> --- Thanks for looking at the package, and sorry for taking so long to reply. (In reply to comment #4) > This is an informal review as I am not sponsored yet. > > > Patch0: %{name}-1.2.2-fedora.patch > > Patch1: %{name}-1.0.1-playerdir.patch > > BuildRequires: boost-devel > > BuildRequires: cegui-devel > > Add a new line between the Patch1 line and the first BuildRequires line. > Cosmetic, but reasonable. Done. > > %description devel > > The %{name}-devel package contains libraries and header files for > > developing applications that use %{name} > > Add a '.' at the end of the description. > Done. > > %package playerplugin > > Maybe name that player-plugin ? > > See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators > I named it "playerplugin" to stay consistent with the Stage package. The separators guidelines are more for keeping underscores out of package names, they don't say much about when to use dashes > > rm -rf $RPM_BUILD_ROOT > > You must stick to macros. > Use %{buildroot}. See > http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot. > 7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS > RPM_BUILD_ROOT and %{buildroot} are interchangable. The guidelines don't prefer one over the other, they just prefer that you pick one and stick with it. >From the linked page: "There is very little value in choosing one style over the other, since they will resolve to the same values in all scenarios. You should pick a style and use it consistently throughout your packaging. " > > %global abiversion 1.2 > > How tightly coupled is the ABI version to the upstream version ? > The abiversion is the first two parts of the release number. I defined it for convenience for the %files section, since gazebo likes to create folders called gazebo-%{abiversion} > > Spec URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo.spec > > $ rpmlint -i gazebo.spec > gazebo.spec: W: patch-not-applied Patch1: %{name}-1.0.1-playerdir.patch > A patch is included in your package but was not applied. Refer to the patches > documentation to see what's wrong. > > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > Fixed. > > SRPM URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo-1.2.5-1.fc17.src.rpm > > I can not find some dependencies. Are they under review ? If so, can you > provide the buzilla entries ? Or are they in rpmfusion ? > They are under review. See the "Depends On" section at the top of the bug. There are links to the packages under review. I've got an updated SRPM with the latest version of gazebo: Spec URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo-1.3.1-1.fc18.src.rpm rpmlint is still messy. The rpath issue should fix itself once ode is unbundled, and the FSF issues are coming from another bundled library (skyx). $ rpmlint gazebo.spec ../RPMS/x86_64/gazebo-*1.3.1* ../RPMS/noarch/gazebo-*1.3.1* gazebo.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti gazebo.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti gazebo.x86_64: W: shared-lib-calls-exit /usr/lib64/libgazebo_ode.so.1.3.1 exit@GLIBC_2.2.5 gazebo.x86_64: W: no-manual-page-for-binary gzfactory-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gzmaster gazebo.x86_64: W: no-manual-page-for-binary gzstats gazebo.x86_64: W: no-manual-page-for-binary gzstats-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gzclient-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gzserver gazebo.x86_64: W: no-manual-page-for-binary gzphysics gazebo.x86_64: W: no-manual-page-for-binary gzsensor gazebo.x86_64: W: no-manual-page-for-binary gzclient gazebo.x86_64: W: no-manual-page-for-binary gztopic gazebo.x86_64: W: no-manual-page-for-binary gzserver-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gzphysics-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gztopic-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gzsensor-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gzsdf gazebo.x86_64: W: no-manual-page-for-binary gzmodel_create.sh gazebo.x86_64: W: no-manual-page-for-binary gazebo-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gzmaster-1.3.1 gazebo.x86_64: W: no-manual-page-for-binary gazebo gazebo.x86_64: W: no-manual-page-for-binary gzfactory gazebo.x86_64: W: no-manual-page-for-binary gzsdf-1.3.1 gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/physics/bullet/BulletScrewJoint.cc gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/SkyX.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/ColorGradient.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/GeometryBlock.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/BasicController.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/LightningManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/CloudsManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/physics/ode/ODEScrewJoint.cc gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/physics/ode/ODEScrewJoint.hh gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/LightningManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/GeometryManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/plugins/RayPlugin.cc gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/Lightning.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/MeshManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/plugins/RayPlugin.hh gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/plugins/ContactPlugin.hh gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/AtmosphereManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/ColorGradient.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/Lightning.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/DataManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/AtmosphereManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/DataManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/GeometryManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/GPUManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/Prerequisites.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/Projector.hh gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/VClouds.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/FastFakeRandom.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/Projector.cc gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/GPUManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/MoonManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/VClouds.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/MeshManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/Ellipsoid.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/BasicController.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/FastFakeRandom.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/MoonManager.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VClouds/Ellipsoid.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/plugins/JointTrajectoryPlugin.cc gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/SkyX.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/VCloudsManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VClouds/GeometryBlock.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/Controller.h gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/src/CloudsManager.cpp gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/plugins/JointTrajectoryPlugin.hh gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/plugins/ContactPlugin.cc gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/physics/bullet/BulletScrewJoint.hh gazebo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gazebo-1.3.1/gazebo/rendering/skyx/include/VCloudsManager.h gazebo-devel.x86_64: W: no-documentation gazebo-devel.x86_64: E: incorrect-fsf-address /usr/include/gazebo-1.3/gazebo/plugins/JointTrajectoryPlugin.hh gazebo-devel.x86_64: E: incorrect-fsf-address /usr/include/gazebo-1.3/gazebo/rendering/Projector.hh gazebo-devel.x86_64: E: incorrect-fsf-address /usr/include/gazebo-1.3/gazebo/plugins/ContactPlugin.hh gazebo-devel.x86_64: E: rpath-in-buildconfig /usr/lib64/pkgconfig/gazebo_transport.pc lines ['9'] gazebo-devel.x86_64: E: rpath-in-buildconfig /usr/lib64/pkgconfig/gazebo.pc lines ['9'] gazebo-devel.x86_64: E: incorrect-fsf-address /usr/include/gazebo-1.3/gazebo/gazebo_core.hh gazebo-devel.x86_64: E: incorrect-fsf-address /usr/include/gazebo-1.3/gazebo/plugins/RayPlugin.hh gazebo-devel.x86_64: E: rpath-in-buildconfig /usr/lib64/pkgconfig/gazebo_ode.pc lines ['9'] gazebo-playerplugin.x86_64: W: no-documentation gazebo-media.noarch: W: no-documentation gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Lightning.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Ground.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Lightning.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_VolClouds_Lightning.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Skydome.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Clouds.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Skydome.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Skydome.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Clouds.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Ground.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_VolClouds.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Ground.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_VolClouds_Lightning.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_VolClouds.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_VolClouds.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Clouds.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Moon.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Lightning.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_VolClouds_Lightning.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Moon.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX_Moon.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-1.3/media/skyx/SkyX.material 6 packages and 1 specfiles checked; 78 errors, 27 warnings. The real issue is that it's still bundling ode, and the bundled version is different than the system version. I'm still working on this. The other dependencies in comment 2 are resolved. I also found two new bundled libraries: skyx and qtpropertybrowser. I'll keep working on those while the other blocker packages are reviewed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u83dc6e5zl&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review