[Bug 891184] nodejs-config-chain - Handle configuration once and for all

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891184

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(tchollingsworth@g
                   |                            |mail.com)

--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Description and Summary OK.

MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.

$ rpmlint ../SRPMS/nodejs-config-chain-1.1.3-2.fc18.src.rpm
../RPMS/noarch/nodejs-config-chain-1.1.3-2.fc18.noarch.rpm
nodejs-config-chain.noarch: W: only-non-binary-in-usr-lib
nodejs-config-chain.noarch: E: script-without-shebang
/usr/lib/node_modules/config-chain/index.js
2 packages and 0 specfiles checked; 1 errors, 1 warnings.

script-without-shebang: probably a permission issue, will look at that later in
the review
only-non-binary-in-usr-lib: false positive

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.

Checked in LICENSE, MIT. OK

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.

$ sha256sum ../SOURCES/config-chain-1.1.3.tgz 
c9d4c022c148174f89da13f26e4e564dac047f4e87f32e614b6f5d988fc21626 
../SOURCES/config-chain-1.1.3.tgz
$ spectool -g nodejs-config-chain.spec 
Getting http://registry.npmjs.org/config-chain/-/config-chain-1.1.3.tgz to
./config-chain-1.1.3.tgz
$ sha256sum config-chain-1.1.3.tgz 
c9d4c022c148174f89da13f26e4e564dac047f4e87f32e614b6f5d988fc21626 
config-chain-1.1.3.tgz

OK

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.

$ rpm -q -lv -p ../RPMS/noarch/nodejs-config-chain-1.1.3-2.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 led 17 04:28
/usr/lib/node_modules/config-chain
-rwxr-xr-x    1 root    root                     7127 lis 14 05:18
/usr/lib/node_modules/config-chain/index.js
-rw-r--r--    1 root    root                      514 lis 14 05:21
/usr/lib/node_modules/config-chain/package.json
drwxr-xr-x    2 root    root                        0 led 17 04:28
/usr/share/doc/nodejs-config-chain-1.1.3
-rw-r--r--    1 root    root                     1070 srp 29 01:46
/usr/share/doc/nodejs-config-chain-1.1.3/LICENCE
-rw-r--r--    1 root    root                     5451 srp 29 01:46
/usr/share/doc/nodejs-config-chain-1.1.3/readme.markdown

FIX: chmod -x index.js

MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK

TODO: Run tests when deps reach Fedora.

Package NEEDSWORK: Correct the permissions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EdPM4Lw2ud&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]