Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891213 --- Comment #5 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to comment #4) > Ok, I understand now. Thanks. > > One thing we should consider working on with upstream would be to implement > a search path so we can avoid those symlinks. That's not a requirement for > this review though. Package approved. Node supports search paths just fine, either by setting $NODE_PATH in the environment or by trivially patching lib/module.js when building node. That doesn't jibe with the way upstream wants module loading to work, though. See https://npmjs.org/doc/faq.html#I-installed-something-globally-but-I-can-t-require-it for instance. The symlinking we do is the equivalent of `npm link`ing dependencies into modules as opposed to `npm install`ing them, and prevents system packages from infecting the module search path while still allowing them to be used for both executables in /usr/bin and in personal projects via `npm link`. Anyway, I'm going to finish up draft packaging guidelines based on what I've been doing in the next day or two with detailed rationales for everything and all that fun stuff, so you and FPC will have plenty of information at FUDCon. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1wdT1Z54xm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review