[Bug 872020] Review Request: ocaml-tplib - Tropical Polyhedra Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=872020

--- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to comment #2)
> This one also have spec and spec from srpm not matching, so I assume
> the spec to use is the one in the srpm.

Oops.  How did I do that?!  You used the correct one.

> I am not familiar with ocaml, so please describe me how it works,
> and that it is correct:
> RPMS/x86_64/ocaml-tplib-1.2-1.fc19.x86_64.rpm:
> mlgmpidl_plugin.cmxs()(64bit)
> ocaml(Halfspace) = 9ea926c8cef685f376a6b194fcc14444
> [...]
> Should it really provide mlgmpidl_plugin.cmxs? I presume the others
> are ok, but does ocaml understand that it must search whatever
> ocaml(Halfspace) in %{_libdir}/ocaml/tplib? I mean, how it
> knows about the tplib subdir? Is it automatically added to some
> kind of search path, or maybe it does a deep search in the
> base directory? Same questions about mlgmpidl_plugin.cmxs.

No, there is nothing automatic here.  Users of this library will have to invoke
the ocaml compiler with "-I +tplib".  The plugins should not be provided; good
catch.  Those are for internal use only.  I have filtered them out.

> The error about static libraries probably should be addressed,
> unless there is some good reason not to, that is, the -devel
> package should also have a:
> Provides: %{name}-static

Done.

> Generating manpages for the binaries probably is optional, but
> should not be too hard to, just that needs some manual parsing
> of help2man output as well as its arguments (e.g. tell to not
> create a look at info page and pass version as argument to
> help2man).

Done.  New URLs:

Spec URL: http://jjames.fedorapeople.org/ocaml-tplib/ocaml-tplib.spec
SRPM URL:
http://jjames.fedorapeople.org/ocaml-tplib/ocaml-tplib-1.2-2.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xbsGWRjT92&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]