Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886908 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> --- As in xonotic review: 1) I would prefer also to have the various tags (Name: Release: etc.) and values separated by some tab if possible, but this is only my opinion. 2) Macros should not be used unless necessary [1], I think %{__rm}, %{__install}, %{__mkdir_p} and %{__sed} should be removed. 3) What are the comments from line 31 to 39 used for? [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Macros Thanks, --Simone -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bb0IFNADZM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review