Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868263 --- Comment #1 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Sorry for delay. Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages ** These files should go to devel subpackage, e.g. libguile-srfi-srfi-1-v-3.so ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. ** Comment above Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. ** I guess there are mentioned many unneeded/compatible licenses in the license tag, I think that LGPLv2+ should be enough for the resulting package, as upstream claims in the LICENSE file. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [-]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package ** Comment above [x]: Package requires other packages for directories it uses. ** Maybe I would like more /usr/share/guile-1.8 than /usr/share/guile/1.8 [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [!]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package devel ** We probably need the %{?_isa} if we support multilib [x]: Package complies to the Packaging Guidelines ** I would use more the mver macro to subst hardcoded macros ** I didn't see the proposed guile-2 spec, so I cannot check whether it is conflict free. The compat spec looks generaly OK. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "BSD (4 clause)", "*No copyright* Public domain", "LGPL (v2.1 or later)". 7 files have unknown license. Detailed output of licensecheck in /home/yarda/git-fedora/guile-compat/review-compat- guile1.8/licensecheck.txt ** See above, there are probably more licenses than needed [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. ** The current name is probably not against guidelines (http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Multiple_packages_with_the_same_base_name) , but other compat packages doesn't use 'dot' delimiter for version, e.g. compat-guile18 instead of compat-guile1.8 ** In case you expect more compat versions to exist in parallel, you may consider compat-db approach, e.g. base name without version and subpackage for each compat version. [?]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) ** I didn't see the guile-2 package, so it's hard to say. [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. ** I think there should be obsoletes and provides. [x]: Package must own all directories that it creates. [?]: Package does not own files or directories owned by other packages. ** I need to see the guile-2 spec. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 163840 bytes in 7 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required ** No blocker, OK for EPEL [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. ** Compat package, probably OK [x]: The placement of pkgconfig(.pc) files are correct. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Patch1 (guile-1.8.7-multilib.patch) Source0 (guile-1.8.8.tar.gz) Patch3 (guile-1.8.8-deplibs.patch) Patch2 (guile-1.8.7-testsuite.patch) ** No blocker [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define. Note: %define mver 1.8 ** Easy fix ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1986560 bytes in /usr/share 10240 compat-guile1.8-devel-1.8.8-1.fc16.x86_64.rpm 1976320 compat- guile1.8-1.8.8-1.fc16.x86_64.rpm ** It's about 2MB of data that could probably go noarch, but no blocker Rpmlint ------- Checking: compat-guile1.8-1.8.8-1.fc16.x86_64.rpm compat-guile1.8-devel-1.8.8-1.fc16.x86_64.rpm compat-guile1.8-debuginfo-1.8.8-1.fc16.x86_64.rpm compat-guile1.8-1.8.8-1.fc16.src.rpm compat-guile1.8.x86_64: W: spelling-error Summary(en_US) extensibility -> sensibility, extensible compat-guile1.8.x86_64: W: spelling-error %description -l en_US extensibility -> sensibility, extensible ** false positive compat-guile1.8.x86_64: E: description-line-too-long C Install the compat-guile1.8 package if you'd like to add extensibility to programs compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-4-v-3.so compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-13-14-v-3.so compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 37: warning: numeric expression expected (got `F') compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 39: warning: numeric expression expected (got `F') compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 55: warning: numeric expression expected (got `E') compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 57: warning: numeric expression expected (got `S') compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-60-v-2.so compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguilereadline-v-17.so compat-guile1.8.x86_64: W: dangling-relative-symlink /usr/share/guile/1.8/slib ../../slib compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-1-v-3.so compat-guile1.8.x86_64: W: no-manual-page-for-binary guile1.8-tools compat-guile1.8.x86_64: W: one-line-command-in-%post /sbin/ldconfig ** this could be easily fixed compat-guile1.8.x86_64: W: dangerous-command-in-%trigger rm compat-guile1.8.x86_64: W: dangerous-command-in-%trigger rm ** probably false positive compat-guile1.8-devel.x86_64: W: spelling-error Summary(en_US) extensibility -> sensibility, extensible compat-guile1.8-devel.x86_64: W: spelling-error %description -l en_US extensibility -> sensibility, extensible compat-guile1.8-devel.x86_64: W: no-documentation compat-guile1.8-devel.x86_64: W: no-manual-page-for-binary guile1.8-snarf compat-guile1.8-devel.x86_64: W: no-manual-page-for-binary guile1.8-config compat-guile1.8.src: W: spelling-error Summary(en_US) extensibility -> sensibility, extensible compat-guile1.8.src: W: spelling-error %description -l en_US extensibility -> sensibility, extensible compat-guile1.8.src: E: description-line-too-long C Install the compat-guile1.8 package if you'd like to add extensibility to programs compat-guile1.8.src:129: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 78) 4 packages and 0 specfiles checked; 2 errors, 24 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint compat-guile1.8-devel compat-guile1.8-debuginfo compat-guile1.8 compat-guile1.8-devel.x86_64: I: enchant-dictionary-not-found en_US compat-guile1.8-devel.x86_64: W: no-documentation compat-guile1.8-devel.x86_64: W: no-manual-page-for-binary guile1.8-snarf compat-guile1.8-devel.x86_64: W: no-manual-page-for-binary guile1.8-config compat-guile1.8.x86_64: E: description-line-too-long C Install the compat-guile1.8 package if you'd like to add extensibility to programs compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-13-14-v-3.so.3.0.1 linux-vdso.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-13-14-v-3.so.3.0.1 /usr/lib64/libguile.so.17 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-13-14-v-3.so.3.0.1 /usr/lib64/libgmp.so.3 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-13-14-v-3.so.3.0.1 /lib64/libcrypt.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-13-14-v-3.so.3.0.1 /lib64/libm.so.6 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-13-14-v-3.so.3.0.1 /usr/lib64/libltdl.so.7 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-13-14-v-3.so.3.0.1 /lib64/libpthread.so.0 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-1-v-3.so.3.0.2 linux-vdso.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-1-v-3.so.3.0.2 /usr/lib64/libgmp.so.3 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-1-v-3.so.3.0.2 /lib64/libcrypt.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-1-v-3.so.3.0.2 /lib64/libm.so.6 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-1-v-3.so.3.0.2 /usr/lib64/libltdl.so.7 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-1-v-3.so.3.0.2 /lib64/libpthread.so.0 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 linux-vdso.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 /usr/lib64/libgmp.so.3 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 /lib64/libcrypt.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 /lib64/libm.so.6 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 /usr/lib64/libltdl.so.7 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 /lib64/libncurses.so.5 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 /lib64/libtinfo.so.5 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguilereadline-v-17.so.17.0.3 /lib64/libpthread.so.0 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-60-v-2.so.2.0.2 linux-vdso.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-60-v-2.so.2.0.2 /lib64/libcrypt.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-60-v-2.so.2.0.2 /lib64/libm.so.6 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-60-v-2.so.2.0.2 /usr/lib64/libltdl.so.7 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-60-v-2.so.2.0.2 /lib64/libpthread.so.0 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-4-v-3.so.3.0.1 linux-vdso.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-4-v-3.so.3.0.1 /usr/lib64/libguile.so.17 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-4-v-3.so.3.0.1 /usr/lib64/libgmp.so.3 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-4-v-3.so.3.0.1 /lib64/libcrypt.so.1 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-4-v-3.so.3.0.1 /lib64/libm.so.6 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-4-v-3.so.3.0.1 /usr/lib64/libltdl.so.7 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile-srfi-srfi-4-v-3.so.3.0.1 /lib64/libpthread.so.0 compat-guile1.8.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libguile.so.17.4.0 linux-vdso.so.1 ** you can try to re-link with --as-needed compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-4-v-3.so compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-13-14-v-3.so compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 37: warning: numeric expression expected (got `F') compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 39: warning: numeric expression expected (got `F') compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 55: warning: numeric expression expected (got `E') compat-guile1.8.x86_64: W: manual-page-warning /usr/share/man/man1/guile1.8.1.gz 57: warning: numeric expression expected (got `S') compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-60-v-2.so compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguilereadline-v-17.so compat-guile1.8.x86_64: W: dangling-relative-symlink /usr/share/guile/1.8/slib ../../slib compat-guile1.8.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguile-srfi-srfi-1-v-3.so compat-guile1.8.x86_64: W: no-manual-page-for-binary guile1.8-tools compat-guile1.8.x86_64: W: one-line-command-in-%post /sbin/ldconfig compat-guile1.8.x86_64: W: dangerous-command-in-%trigger rm compat-guile1.8.x86_64: W: dangerous-command-in-%trigger rm 3 packages and 0 specfiles checked; 1 errors, 51 warnings. # echo 'rpmlint-done:' Requires -------- compat-guile1.8-1.8.8-1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig coreutils ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypt.so.1()(64bit) libgmp.so.3()(64bit) libguile-srfi-srfi-1-v-3.so.3()(64bit) libguile-srfi-srfi-13-14-v-3.so.3()(64bit) libguile-srfi-srfi-4-v-3.so.3()(64bit) libguile-srfi-srfi-60-v-2.so.2()(64bit) libguile.so.17()(64bit) libguilereadline-v-17.so.17()(64bit) libltdl.so.7()(64bit) libm.so.6()(64bit) libncurses.so.5()(64bit) libpthread.so.0()(64bit) libreadline.so.6()(64bit) libtinfo.so.5()(64bit) rtld(GNU_HASH) compat-guile1.8-devel-1.8.8-1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /bin/sh /usr/bin/guile1.8 /usr/bin/pkg-config compat-guile1.8 = 5:1.8.8-1.fc16 gmp-devel libguile.so.17()(64bit) pkgconfig compat-guile1.8-debuginfo-1.8.8-1.fc16.x86_64.rpm (rpmlib, GLIBC filtered): Provides -------- compat-guile1.8-1.8.8-1.fc16.x86_64.rpm: compat-guile1.8 = 5:1.8.8-1.fc16 compat-guile1.8(x86-64) = 5:1.8.8-1.fc16 libguile-srfi-srfi-1-v-3.so.3()(64bit) libguile-srfi-srfi-13-14-v-3.so.3()(64bit) libguile-srfi-srfi-4-v-3.so.3()(64bit) libguile-srfi-srfi-60-v-2.so.2()(64bit) libguile.so.17()(64bit) libguilereadline-v-17.so.17()(64bit) compat-guile1.8-devel-1.8.8-1.fc16.x86_64.rpm: compat-guile1.8-devel = 5:1.8.8-1.fc16 compat-guile1.8-devel(x86-64) = 5:1.8.8-1.fc16 pkgconfig(guile-1.8) = 1.8.8 compat-guile1.8-debuginfo-1.8.8-1.fc16.x86_64.rpm: compat-guile1.8-debuginfo = 5:1.8.8-1.fc16 compat-guile1.8-debuginfo(x86-64) = 5:1.8.8-1.fc16 Unversioned so-files -------------------- compat-guile1.8-1.8.8-1.fc16.x86_64.rpm: /usr/lib64/libguile-srfi-srfi-1-v-3.so compat-guile1.8-1.8.8-1.fc16.x86_64.rpm: /usr/lib64/libguile-srfi-srfi-13-14-v-3.so compat-guile1.8-1.8.8-1.fc16.x86_64.rpm: /usr/lib64/libguile-srfi-srfi-4-v-3.so compat-guile1.8-1.8.8-1.fc16.x86_64.rpm: /usr/lib64/libguile-srfi-srfi-60-v-2.so compat-guile1.8-1.8.8-1.fc16.x86_64.rpm: /usr/lib64/libguilereadline-v-17.so MD5-sum check ------------- ftp://ftp.gnu.org/pub/gnu/guile/guile-1.8.8.tar.gz : CHECKSUM(SHA256) this package : c3471fed2e72e5b04ad133bbaaf16369e8360283679bcf19800bc1b381024050 CHECKSUM(SHA256) upstream package : c3471fed2e72e5b04ad133bbaaf16369e8360283679bcf19800bc1b381024050 Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-16-x86_64 Command line :/usr/bin/fedora-review -n compat-guile Please provide the guile-2 spec to allow me to do more deep checks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8X3wQnnhKI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review