Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891339 --- Comment #4 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to comment #3) > Issues, in no particular order: > > 1. The initial changelog entry in the spec file says: "Set license to GPLv2, > can't find any LGPL files." However, "grep -FR LGPL ." shows 10 files > that claim to be under the LGPL: compat.h, compat-unix.c, dataPackets.c, > dataPackets.h, iguanaIR.c, iguanaIR.h, pipes.c, pipes.h, support.c, and > support.h. If I'm reading the Makefile correctly, that means that > %{_libdir}/libiguanaIR.so.0 is LGPL, as is the entire -devel subpackage, > and everything else is GPL. It might be worth splitting the library out > into its own subpackage to keep the license situation clear. (That would > also enable multilib builds, which you may not care about.) One of those errors I just can't explain...fixed. > 2. The main RPM installs a file into /etc/logrotate.d, but doesn't Require > logrotate. If you think this is not necessary, please justify. Will not justify, adding a Requires: instead. Fixed. > 3. The firmware subpackage is noarch, but uses the %{_isa} macro. That macro > would seem to be nonsensical in a noarch context. To much copy-paste, to little thinking... Fixed > 4. The main package owns the two .so files in %{_libdir}/iguanaIR, but does > not own %{_libdir}/iguanaIR itself. So let's claim complete directory instead. Fixed, > 5. Add "-p" to the invocations of "install" that install files, rather than > those that create directories, to preserve timestamps. Fixed Updated in-place, same links, no release bump (but a changelog entry) BTW, most of the patches are accepted upstream. Might make sense to release a git snapshot after the first release. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z6S7l2Y3pE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review