Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speedcrunch - a KDE power user calculator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228591 ------- Additional Comments From panemade@xxxxxxxxx 2007-02-22 00:46 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM + source files match upstream. e9a94f6a054c1332483024ee035d3a79 speedcrunch-0.7-beta2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available but not handled with %find_lang. + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. - Desktop file installed correctly but not able to view it under Applications Menu. + GUI app. SHOULD: desktop file should be viewable under applications menu. Update Desktop file and submit new package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review