Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895541 --- Comment #10 from Kalev Lember <kalevlember@xxxxxxxxx> --- Some drive-by comments: 1) Should use the %{version} in the %Source URL, this way there's only one place where you need to update the version number afterwards. 2) > BuildRequires: atk > BuildRequires: gdk-pixbuf2 > BuildRequires: pango These should probably read 'atk-devel', 'gdk-pixbuf2', and 'pango-devel' instead. The -devel packages have the needed .so symlinks / pkgconfig files that are needed for linking against these libraries. Note that it would probably be safe to just remove these 3 lines; gtk2-devel should drag them in by its requires. But you can list them explicitly too if you want to, either way works. You can verify that all the needed BuildRequires are in place by doing koji scratch builds. Follow the instructions at the https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Install_the_client_tools_.28Koji.29_and_set_up_your_certificate page and then adjust the build requires until the scratch builds succeed. 'koji build --scratch ptbl-1.0-1.fc18.src.rpm'. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7jQhQvaJPz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review