Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894610 --- Comment #8 from Jerry James <loganjerry@xxxxxxxxx> --- Issues, in no particular order: 1. The summary is, I think, unhelpful. Consider making the summary contain the same text as the description. 2. As rpmlint notes, this noarch package uses the %{_libdir} macro. That doesn't really make sense: the whole point of a noarch package is that it can be installed on *any* arch. So are the contents of the package going to be installed into /usr/lib or /usr/lib64? It has to be the same on every system. For this package, it is probably better to put the pkgconfig file in %{_datadir}/pkgconfig instead. You can probably just use sed or perl to change the definition of pkgconfiglibdir in Makefile.in to be $(datadir)/pkgconfig. (I haven't actually tried that.) 3. Rpmlint also complains about the pkgconfig file not being in -devel. Since this package is intended to be used only for testing other packages, it essentially is a -devel package, so we can ignore that. 4. It might be a good idea to capture part of comment 4 into a file to be included in %doc as the equivalent of a COPYING file. Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/jamesjer/894610-coin-or-Sample/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Perhaps including Tom's comment is sufficient. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: coin-or-Sample-1.2.3-2.fc19.noarch.rpm : /usr/lib/pkgconfig/coindatasample.pc [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (Sample-1.2.3.tgz) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: coin-or-Sample-1.2.3-2.fc19.noarch.rpm coin-or-Sample-1.2.3-2.fc19.src.rpm coin-or-Sample.noarch: W: no-documentation coin-or-Sample.noarch: W: devel-file-in-non-devel-package /usr/lib/pkgconfig/coindatasample.pc coin-or-Sample.src:28: W: libdir-macro-in-noarch-package (main package) %{_libdir}/pkgconfig/* 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint coin-or-Sample coin-or-Sample.noarch: W: no-documentation coin-or-Sample.noarch: W: devel-file-in-non-devel-package /usr/lib/pkgconfig/coindatasample.pc 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- coin-or-Sample-1.2.3-2.fc19.noarch.rpm (rpmlib, GLIBC filtered): /usr/bin/pkg-config Provides -------- coin-or-Sample-1.2.3-2.fc19.noarch.rpm: coin-or-Sample = 1.2.3-2.fc19 pkgconfig(coindatasample) = 1.2.3 MD5-sum check ------------- http://www.coin-or.org/download/source/Data/Sample-1.2.3.tgz : CHECKSUM(SHA256) this package : 89980068fc00acc4bb32b32b7911f6077f208be0786f3dfb687f6de84089ff47 CHECKSUM(SHA256) upstream package : 89980068fc00acc4bb32b32b7911f6077f208be0786f3dfb687f6de84089ff47 Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-i386 Command line :/usr/bin/fedora-review -b 894610 -m fedora-rawhide-i386 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tmVUgDZFuj&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review