[Bug 895541] Review Request: ptbl - Periodic Table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895541

--- Comment #3 from Antonio Trande <trpost@xxxxxxxxxxxx> ---
(In reply to comment #2)
> Antonio Trande,
>  spec file is changed according to your suggestion and new spec and srpm
> uploaded in the same url

Not quite right. ;)

At the comment #2 I add:

- Group tag is optional
(http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag), however
'Education' is not valid as you can see by using 'rpmlint' command:

$ rpmlint -I non-standard-group
non-standard-group:
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "Unspecified", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

- 'BuildRequires:  gnome-doc-utils >= 0.3.2'  is missing.

- "Your package should own all of the files that are installed as part of the
%install process."
http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

In my opinion, you should do some changes. ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zDToIHMTFo&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]