[Bug 853922] Review Request: guacamole - The main Guacamole web application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=853922

--- Comment #18 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> ---
(In reply to comment #15)
> > [!]: If package contains pom.xml files install it (including depmaps) even
> >      when building with ant
> > >>>> Pom.xml file is present, but is not installed. Please, install it.
> 
> Done, I put only the pom.xml file as %add_maven_depmap throws an error.

Depmap should be installed too. If you get an error message (or exception
trace) then feel free to join our IRC channel (#fedora-java on freenode), we
should be able to help.

> > [!]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
> > >>>> Line 96 should not copy the apidocs folder, but its contents:
> > >>>> cp -rp target/site/apidocs/* %{buildroot}%{javadocdir}/%{name}/
> > >>>> Currently there is the unnecessary directory apidocs in the path.
> 
> Corrected, but the Packaging Guidelines at
> https://fedoraproject.org/wiki/Packaging:Java#maven_3
> suggest to copy directly the directory:
> 
> mkdir -p $RPM_BUILD_ROOT%{_javadocdir}/%{name}
> cp -rp [javadoc directory] $RPM_BUILD_ROOT%{_javadocdir}/%{name}

This is a "bug" in the guidelines :)
It should be [javadoc files] or [javadoc directory]/*

(In reply to comment #16)
> guacamole.src: W: invalid-license AGPLv3+
> 
> I do not understand this, is it an rpmlint bug? The license is listed as
> valid in the package guidelines, fedora-review marks it ok and rpmlint does
> not.

New licenses are added frequently so there is a delay between licensing page,
so obviously rpmlint can't always contain the up-to-date list of license.
That's especially true if you are using older (stable) releases instead of
Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fdgt00JSR9&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]