Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=895541 Antonio Trande <trpost@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trpost@xxxxxxxxxxxx --- Comment #1 from Antonio Trande <trpost@xxxxxxxxxxxx> --- Hi RubraB. Just few initial comments. - Buildroot tag is necessary only if this package will be supported in EPEL5 and below. If it be so, "The BuildRoot value MUST be below %{_tmppath}/ and MUST contain at least %{name}, %{version} and %{release}. It may invoke mktemp since this is guaranteed to exist on every system. From there, packagers are expected to use a sane BuildRoot." http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag - NEWS and README files are empty. They can be erased. - Changelog is empty. Why ? http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - You should consider macros' use. For instance: %{_bindir}/%{name} instead %{_bindir}/ptbl -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qy16bpHXwJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review