Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894338 --- Comment #7 from Ramon de C Valle <rcvalle@xxxxxxxxxx> --- (In reply to comment #6) > That can only be because you misunderstand Eric's review in comment 1 and my > comment 2. > > More slowly then, okay. From comment 1, where fedora-review reported this > packaging failure: > > [!]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > > This is a false positive. You could not move /usr/lib64/libdistorm3.so to > the -devel package, because it is the only file in the base package. And it > is a run-time library, not a development file. > > [...] > > I see you've updated the spec file silently. Please bump the "Release" > version when you do that, and maintain the %changelog section, too. I didn't updated it "silently". I'm working with Eric and notified him about the update. And even before I updated it, none of the resulting packages were empty. > > The updated src.rpm still suffers from several issues. What you've changed > silently with regard to the shared library doesn't make sense. > > Do run "rpmlint -i" on both the src.rpm and the built rpms. Also try a > simple "rpmbuild --rebuild" with your src.rpm. It cannot be built more than > once because of the weird things you do in %prep: > > $ rpmbuild --rebuild libdistorm-3.3-1.fc18.src.rpm > Installing libdistorm-3.3-1.fc18.src.rpm > warning: user rcvalle does not exist - using root > warning: group rcvalle does not exist - using root > warning: user rcvalle does not exist - using root > warning: group rcvalle does not exist - using root > Executing(%prep): /bin/sh -e /home/ms18b/tmp/rpm/tmp/rpm-tmp.lelXoK > + umask 022 > + cd /home/ms18b/tmp/rpm/BUILD > + unzip /home/ms18b/tmp/rpm/SOURCES/libdistorm-3.3/distorm3.zip > Archive: /home/ms18b/tmp/rpm/SOURCES/libdistorm-3.3/distorm3.zip > replace distorm3/COPYING? [y]es, [n]o, [A]ll, [N]one, [r]ename: > ^C Just type "A". In addition, it doesn't happen for the "silently" updated Spec file anymore because I added the lines for removing the unpacked sources from previous builds, if any. Can you enumerate which "weird" things I do on prep? Btw, are you planning helping with anything? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HGpNivU4eC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review