[Bug 846488] Review Request: babeltrace - Trace Viewer and Converter, mainly for the Common Trace Format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=846488

--- Comment #10 from Yannick Brosseau <yannick.brosseau@xxxxxxxxx> ---
(In reply to comment #8)
> A few things. You have the same file being owned my multiple packages.
> 
> You only need to include the license file once if a package that it is
> provided by a parent package.
> 
> Use %doc in the main package and then remove them from the sub-packages. As
> long as the license files are present for every possibly combination of
> installed packages.
> %doc LICENSE gpl-2.0.txt mit-license.txt ChangeLog
> in only the main babeltrace and libbabeltrace packages.
> You could then drop the /usr/share/doc/babeltrace directory altogether.

>From what I understand, I cannot do that, because these documentation files are
installed by the make install of the upstream package. 
%doc seems to be used if you have non installed file that you want to add to
the package. 


> You should also run the binary generated under tests in the %check section

The make check entry is running the test normally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LR87lrLGdP&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]