Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883472 --- Comment #8 from Radek Pazdera <rpazdera@xxxxxxxxxx> --- (In reply to comment #7) > - Why is the main package empty and doesn't get built? Wouldn't it make more > sense to move the files from the -common subpackage to the main package? I used this to indicate that the things currently lnst-common alone are practically useless without either lnst-ctl or lnst-slave. Installing "lnst" pacakge only might lead someone to to think that it is sufficient to get everything (which is not). But if this is not the preferred way, I can move the -common to the main package. > - AFAICS the license is GPLv2+ You're right. I'm sorry for the confusion. Will fix it. > - Just to say it here, the .c and .h files are not in the -devel subpackage > because they are needed for "runtime" of the package, is that correct? That is correct. It is sort-of library of test cases (very small at the moment - the project is young) that the controller will distribute to its slaves to compile and execute remotely. > - According to [1], it seems that your package is a prerelease and therefore > the release tag should be "0.x" instead of "x" (while keeping the git stuff, > of course). I must have missed that as well. I'll fix it. > > [1] > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre- > Release_packages Thank you very much for taking this review :-)! I will re-post the package after we agree whether to use -common or not. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zIwmVAEDcQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review