[Bug 892335] Review Request: AudioCuesheetEditor (v0.2.1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=892335

Michael Schwendt <mschwendt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |NotReady

--- Comment #7 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
I've been away for a week and need to catch up with accumulated mail.

The provided spec file has not been tested by you at all. :(  It fails for
simple commands, such as rpmbuild -bs and -bb, because the download link for
the source tarball results in a wrong file name. For a last try, I've given
"spectool -g AudioCueSheet.spec" a try, and it redownloaded the tarball as a
file with name "download" because of the Source0 URL you use. That may be a
temporary work-around, but needs fixing.

Finally, the built src.rpm failed early with Fedora 18 for rpmbuild -bb: line
29: xbuild: command not found

A build requirement is missing.
I've stopped there.

The spec file also still suffers from issues I've pointed out in the old
ticket. You won't manage to maintain an RPM package if you don't care about
packaging topics.

Please provide a src.rpm that builds for you with either plain rpmbuild, Mock
or in the official Fedora Build System:

 
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Install_the_client_tools_.28Koji.29_and_set_up_your_certificate

 
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Upload_Your_Package


If your released upstream source tarball doesn't build at all, this is beyond
the scope of a Fedora Package Review Request. I see you've asked about xbuild
in another place already, note that there's also a Fedora "mono" list, perhaps
with subscribers who can help:
https://admin.fedoraproject.org/mailman/listinfo/mono

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gpSNaDdZal&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]