Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=892682 --- Comment #5 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- This was my first review of a sugar package. That's why there were some differences to other reviews. Would be fine to have some explanations at http://fedoraproject.org/wiki/Packaging:SugarActivityGuidelines: Although a sugar activity is a graphical application, a *.desktop file is not needed. At least the existing activity packages doesn't have one. So this has to be mentioned explicitely in the guidelines. I was a bit mislead by the "python" build requirement. Indeed, python*-devel is not needed, just "python" is sufficient. But to go conform with our Python guidelines, either "python2" or "python3" should be required. As far as I can see, there are no Sugar packages available for EPEL 5. That's why the following stuff from the sample spec file is obsolete and has to be removed: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ... rm -rf $RPM_BUILD_ROOT (in %install) ... %clean rm -rf $RPM_BUILD_ROOT Would be nice to see the changes soon at the wiki pages. This could be a step ahead to make Sugar packages more attractive for reviewers. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nj1Dv4cguZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review