Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863793 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mhroncok@redhat.c | |om) --- Comment #13 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Status: NEEDS WORK ==== Blocker Issues ==== - Please provide access to the application in /usr/bi. (If it's worth providing a .desktop file, it's worth putting in /usr/bin as well. ;-) - This package removes files from the BUILD directory in %install. This breaks `rpmbuild --short-circuit`. Remove these files in %prep or from %buildroot post-install instead. - This package installs documentation in %{python_sitelib}, instead of using %doc. Please use %doc, unless there is a clear, documented, reason not to. - This package contains unnecessary shebang lines in %{python_sitelib}. Please remove these in %prep. - The spec file contains macros in the changelog. Please escape them (e.g. "%%{python_sitelib}" or otherwise remove them. See the rpmlint section at the bottom of the review for more details on the last two issues. ==== Other Issues ==== - This package contains code that may be under other licenses than the primary license. Consider reflecting this fact in the License tag. (See the section of the review pertaining to this for more details.) - The packager has indicated that upstream is including a LICENSE file in a future release. Please do not forget to include this file when the new version is released. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Don't forget to include this once upstream provides it. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3 or later)", "*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/fedora/patches/863793-skeinforge/licensecheck.txt I think licensecheck may think the AGPL is the GPL If not, you might want to add e.g. "and GPLv2+ and GPLv3+", though it isn't strictly necessary since the AGPL ends up being the most restrictive license. [-]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (50_reprap_python_beanshell.zip) Not a blocker, you don't control upstream's naming scheme. ;-) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: skeinforge-doc-12.03.14-11.fc19.noarch.rpm skeinforge-12.03.14-11.fc19.noarch.rpm skeinforge-12.03.14-11.fc19.src.rpm skeinforge-doc.noarch: W: no-documentation skeinforge.noarch: W: no-documentation Okay; the packager is waiting on a new upstream release with a LICENSE file. skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/RepRapArduinoSerialSender.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/preface.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/example.py 0644L /usr/bin/python skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/send.py 0644L /usr/bin/python2.5 skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/limit.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/alteration.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/widen.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/fill.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/scale.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/frank_davies/t.sh 0644L /bin/sh skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/inset.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/bottom.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/dimension.py 0644L /usr/bin/env Please remove the unnecessary shebang lines in %prep. skeinforge.src:57: W: macro-in-%changelog %{_datadir} skeinforge.src:57: W: macro-in-%changelog %{name} skeinforge.src:58: W: macro-in-%changelog %{python_sitelib} skeinforge.src:58: W: macro-in-%changelog %{name} skeinforge.src:78: W: macro-in-%changelog %{_datadir} Please escape these macros. (e.g. %%{_datadir}) 3 packages and 0 specfiles checked; 13 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint skeinforge-doc skeinforge skeinforge-doc.noarch: W: no-documentation skeinforge.noarch: W: no-documentation skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/RepRapArduinoSerialSender.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/preface.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/example.py 0644L /usr/bin/python skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/send.py 0644L /usr/bin/python2.5 skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/limit.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/alteration.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/widen.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/fill.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/scale.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/fabmetheus_utilities/miscellaneous/fabricate/frank_davies/t.sh 0644L /bin/sh skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/inset.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/bottom.py 0644L /usr/bin/env skeinforge.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/skeinforge/skeinforge_application/skeinforge_plugins/craft_plugins/dimension.py 0644L /usr/bin/env 2 packages and 0 specfiles checked; 13 errors, 2 warnings. All addressed above. Requires -------- skeinforge-doc-12.03.14-11.fc19.noarch.rpm (rpmlib, GLIBC filtered): skeinforge = 12.03.14-11.fc19 skeinforge-12.03.14-11.fc19.noarch.rpm (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python python(abi) = 2.7 python2 tkinter Provides -------- skeinforge-doc-12.03.14-11.fc19.noarch.rpm: skeinforge-doc = 12.03.14-11.fc19 skeinforge-12.03.14-11.fc19.noarch.rpm: skeinforge = 12.03.14-11.fc19 MD5-sum check ------------- http://fabmetheus.crsndoo.com/files/50_reprap_python_beanshell.zip : CHECKSUM(SHA256) this package : ba978c6bc6301cb7082cf8da1ee94eee376cd7e8885ddc1bd094bcf7511d060a CHECKSUM(SHA256) upstream package : ba978c6bc6301cb7082cf8da1ee94eee376cd7e8885ddc1bd094bcf7511d060a Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b863793 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kAVTVF4GuY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review