Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890872 --- Comment #7 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to comment #6) > (In reply to comment #5) > Thanks for the review. > > > [!]: Large documentation must go in a -doc subpackage. > > Note: Documentation size is 1075200 bytes in 8 files. > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > Will look at that. With all due respect to fedora-review, I'm not sure 1MB is excessively large. However, the package would only be like half a megabyte instead of 1.7MB without it, so maybe it has a point. Since the Packaging Guidelines don't provide any sort of hard limit on when to subpackage documentation, I don't think I can block the review oh this issue, so I leave this to your discretion. BTW, don't forget to "%doc Documentation/License.txt" in the main package if you end up subpackaging this. > > [!]: BSD license is indicated in addition to the primary MIT license, but no > > comment is provided indicating what is under this license. > I found that more complicated, so I just dropped this comment: > # See License.txt for more information > Isn't that enough? That'll work great, thanks. > > [%]: There is no %check section. If upstream provides test cases, consider > > adding them. If tests cannot be run in koji (e.g. since this requires > > graphics), consider documenting that fact in the spec file. > I cannot find any test, do you see them? Thanks. There are some Test directories in the Examples directory, though they're probably not intended for the kind of thing %check is intended for. I'm fairly certain even if proper test cases did exist, you wouldn't be able to run them in koji. This was only mentioned just to make sure you dotted your i's and crossed your t's. ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BMscJ5Ugw0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review