Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891229 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Summary and Description OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint ../SRPMS/nodejs-request-2.12.0-2.src.rpm ../RPMS/noarch/nodejs-request-2.12.0-2.noarch.rpm nodejs-request.noarch: W: only-non-binary-in-usr-lib nodejs-request.noarch: W: dangling-symlink /usr/lib/node_modules/request/node_modules/form-data /usr/lib/node_modules/form-data nodejs-request.noarch: W: dangling-symlink /usr/lib/node_modules/request/node_modules/mime /usr/lib/node_modules/mime 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Symlinks OK, package requires npm(form-data) and npm(mime) False positive. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. License chcecked in LICENSE file: ASL 2.0. OK License chcecked in vendor/cookie/*: MIT. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. $ sha256sum ../SOURCES/request-2.12.0.tgz a26790d2179da11a644d5deaa2ae5d37472bf0e73355fde02ea5923106308997 ../SOURCES/request-2.12.0.tgz $ spectool -g nodejs-request.spec Getting http://registry.npmjs.org/request/-/request-2.12.0.tgz to ./request-2.12.0.tgz $ sha256sum request-2.12.0.tgz a26790d2179da11a644d5deaa2ae5d37472bf0e73355fde02ea5923106308997 request-2.12.0.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. FIX: The MIT licensed part in vendor/cookie seems like a bundling of https://github.com/LearnBoost/tobi/tree/master/lib/cookie However, I might be wrong, so please correct me, if I am. It's not like I want to make this scope even bigger, just for fun ;) MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-request-2.12.0-2.noarch.rpm drwxr-xr-x 2 root root 0 led 11 19:25 /usr/lib/node_modules/request -rw-r--r-- 1 root root 3591 lis 9 22:48 /usr/lib/node_modules/request/aws.js -rw-r--r-- 1 root root 3346 lis 9 22:48 /usr/lib/node_modules/request/forever.js -rw-r--r-- 1 root root 33675 lis 9 22:48 /usr/lib/node_modules/request/main.js drwxr-xr-x 2 root root 0 led 11 19:25 /usr/lib/node_modules/request/node_modules lrwxrwxrwx 1 root root 31 led 11 19:25 /usr/lib/node_modules/request/node_modules/form-data -> /usr/lib/node_modules/form-data lrwxrwxrwx 1 root root 26 led 11 19:25 /usr/lib/node_modules/request/node_modules/mime -> /usr/lib/node_modules/mime -rw-r--r-- 1 root root 1086 lis 9 22:48 /usr/lib/node_modules/request/oauth.js -rw-r--r-- 1 root root 563 lis 9 22:50 /usr/lib/node_modules/request/package.json -rw-r--r-- 1 root root 6403 lis 9 22:48 /usr/lib/node_modules/request/tunnel.js -rw-r--r-- 1 root root 627 lis 9 22:48 /usr/lib/node_modules/request/uuid.js drwxr-xr-x 2 root root 0 led 11 19:25 /usr/lib/node_modules/request/vendor drwxr-xr-x 2 root root 0 led 11 19:25 /usr/lib/node_modules/request/vendor/cookie -rw-r--r-- 1 root root 1272 bře 23 2012 /usr/lib/node_modules/request/vendor/cookie/index.js -rw-r--r-- 1 root root 1447 lis 15 2011 /usr/lib/node_modules/request/vendor/cookie/jar.js drwxr-xr-x 2 root root 0 led 11 19:25 /usr/share/doc/nodejs-request-2.12.0 -rw-r--r-- 1 root root 9140 led 27 2011 /usr/share/doc/nodejs-request-2.12.0/LICENSE -rw-r--r-- 1 root root 10432 říj 28 18:30 /usr/share/doc/nodejs-request-2.12.0/README.md OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK TODO: Please consider running tests when dependencies are ready for Fedora. Resolution: NEEDSWORK. Basically, the only problem is the bundling. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pjWDGmnr4a&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review