Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891224 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Summary and Description OK. MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint ../SRPMS/nodejs-read-installed-0.0.4-2.fc18.src.rpm ../RPMS/noarch/nodejs-read-installed-0.0.4-2.fc18.noarch.rpm nodejs-read-installed.noarch: W: only-non-binary-in-usr-lib nodejs-read-installed.noarch: W: dangling-symlink /usr/lib/node_modules/read-installed/node_modules/slide /usr/lib/node_modules/slide nodejs-read-installed.noarch: W: dangling-symlink /usr/lib/node_modules/read-installed/node_modules/read-package-json /usr/lib/node_modules/read-package-json nodejs-read-installed.noarch: W: dangling-symlink /usr/lib/node_modules/read-installed/node_modules/semver /usr/lib/node_modules/semver 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Symlinks OK (package requires npm(read-package-json), npm(semver) and npm(slide)) All false positives. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK MUST: The package must meet the Packaging Guidelines. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. License chcecked in LICENSE file: BSD. OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK MUST: The spec file must be written in American English. OK MUST: The spec file for the package MUST be legible. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. $ sha256sum ../SOURCES/read-installed-0.0.4.tgz 18eeff81d5010de0445e2707de77a9ce71dd7bf193b98c58289837004a0383a3 ../SOURCES/read-installed-0.0.4.tgz $ spectool -g nodejs-read-installed.spec Getting http://registry.npmjs.org/read-installed/-/read-installed-0.0.4.tgz to ./read-installed-0.0.4.tgz $ sha256sum read-installed-0.0.4.tgz 18eeff81d5010de0445e2707de77a9ce71dd7bf193b98c58289837004a0383a3 read-installed-0.0.4.tgz OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK, builds in mock MUST: Packages must NOT bundle copies of system libraries. OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK MUST: Permissions on files must be set properly. $ rpm -q -lv -p ../RPMS/noarch/nodejs-read-installed-0.0.4-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 led 11 18:43 /usr/lib/node_modules/read-installed drwxr-xr-x 2 root root 0 led 11 18:43 /usr/lib/node_modules/read-installed/node_modules lrwxrwxrwx 1 root root 39 led 11 18:43 /usr/lib/node_modules/read-installed/node_modules/read-package-json -> /usr/lib/node_modules/read-package-json lrwxrwxrwx 1 root root 28 led 11 18:43 /usr/lib/node_modules/read-installed/node_modules/semver -> /usr/lib/node_modules/semver lrwxrwxrwx 1 root root 27 led 11 18:43 /usr/lib/node_modules/read-installed/node_modules/slide -> /usr/lib/node_modules/slide -rw-r--r-- 1 root root 588 pro 15 21:58 /usr/lib/node_modules/read-installed/package.json -rw-r--r-- 1 root root 9376 pro 15 21:57 /usr/lib/node_modules/read-installed/read-installed.js drwxr-xr-x 2 root root 0 led 11 18:43 /usr/share/doc/nodejs-read-installed-0.0.4 -rw-r--r-- 1 root root 1310 zář 12 02:46 /usr/share/doc/nodejs-read-installed-0.0.4/LICENSE -rw-r--r-- 1 root root 304 čen 12 2012 /usr/share/doc/nodejs-read-installed-0.0.4/README.md OK MUST: Each package must consistently use macros. OK MUST: The package must contain code, or permissable content. OK MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK MUST: Packages must not own files or directories already owned by other packages. OK MUST: All filenames in rpm packages must be valid UTF-8. OK SHOULD: The reviewer should test that the package builds in mock. OK SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. OK TODO: Please consider running test, I belive it has no unresolved dependency. Resolution: APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s6BTkcGlpr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review