Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=870978 Adrian Reber <adrian@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-01-11 11:29:19 --- Comment #9 from Adrian Reber <adrian@xxxxxxxx> --- (In reply to comment #8) > I'd thought I might find a bit of time and fix the libcdio broken dep for > Audacious before Mon/Tue, but upon taking a look at how to handle this new > build requirement, I've run into this: > > $ rpmls -p libcdio-paranoia-devel-10.2+0.90-5.fc19.x86_64.rpm|grep inc > -rw-r--r-- /usr/include/cdio/cdda.h > drwxr-xr-x /usr/include/cdio/paranoia > -rw-r--r-- /usr/include/cdio/paranoia.h > -rw-r--r-- /usr/include/cdio/paranoia/cdda.h > -rw-r--r-- /usr/include/cdio/paranoia/paranoia.h > > Why are there copies of the headers in two locations? > The spec doesn't tell: There is a commit in the upstream git which will move the headers for the next release: https://github.com/rocky/libcdio-paranoia/commit/b2807f3c7a4126b6078d96adbd37c3760b9f41ab Therefore I provide the header files in the old location as well as in the new location. For the new location every package requiring it needs to be changed. The spec has these lines: # copy include files to an additional directory # this will probably be the location for future releases see: # https://github.com/rocky/libcdio-paranoia/commit/b2807f3c7a4126b6078d96adbd37c3760b9f41ab mkdir -p $RPM_BUILD_ROOT%{_includedir}/cdio/paranoia cp -a $RPM_BUILD_ROOT%{_includedir}/cdio/*.h $RPM_BUILD_ROOT%{_includedir}/cdio/paranoia > > # fix wrong installation of header files > > sed -i -e "s,includedir)/cdio,includedir)/cdio/paranoia,g" include/cdio/paranoia/Makefile.in > > > There are two more mistakes which should have been caught during review: > > > %package devel > > Requires: %{name} = %{version}-%{release} > > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > > > > # another multilib fix; remove the architecture information from version.h > > sed -i -e "s,%{version}.*$,%{version}\\\",g" include/cdio/paranoia/version.h This is a leftover from the original libcdio.spec on which this is based. I will remove it. > ??? This file is not installed, not packaged, not used. Btw, if the > expression didn't match, nothing would be substituted either, the "fix" > would be missing. For sed substitutions like this you ought to add a guard > to the spec file (e.g. via grep), or use a patch instead. Thanks for the re-review. I have updated the spec in git. Also closing the still open bug. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jmeXq4SXR4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review