Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Pete Travis <me@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |me@xxxxxxxxxxxxxx Whiteboard| | NotReady Flags| |needinfo+ Flags| |needinfo?(mhroncok@redhat.c | |om) --- Comment #12 from Pete Travis <me@xxxxxxxxxxxxxx> --- Hey Miro, I'd like to tackle this review, assuming you have a sponsor. Please bear with me - I'm new at this, but I'm not afraid to ask for help :) A couple comments after a quick look: Cited license is AGPLv3, but the included COPYING file is GPLv3. These should match. Not all included files use the same licence, and some files do not declare a license. The relationship between `printrun` and `skeinforge` is a little confusing. The SPEC for printrun looks like it is working with skeinforge files and directories. You'll want to make sure there are no conflicts between these related packages. There are no upstream URLs for Source1, Source2, Source3. All sources should have a valid URL. You're using the generated pronterface.lang with the common package; it should probably go with the pronterface files rpmlint complains about macros in changelog; you probably don't need to be so specific about the change made. The locales loop is failing in my build log, you should investigate. I hope this helps get the ball rolling, will check in again soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tI8x3wkM73&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review